fix(deps): update dependency prettier-plugin-astro to v0.14.1 - abandoned#182
fix(deps): update dependency prettier-plugin-astro to v0.14.1 - abandoned#182renovate[bot] wants to merge 2 commits into
Conversation
|
|
WalkthroughThe changes involve modifications to function signatures and type definitions across various files in the Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Config
User->>Config: Call function with options
Config->>Config: Process options
Config-->>User: Return Promise
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 20
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files ignored due to path filters (1)
pnpm-lock.yamlis excluded by!**/pnpm-lock.yaml
Files selected for processing (16)
- packages/eslint-config/scripts/typegen.ts (1 hunks)
- packages/eslint-config/src/configs/formatting.ts (2 hunks)
- packages/eslint-config/src/configs/html.ts (1 hunks)
- packages/eslint-config/src/configs/javascript.ts (1 hunks)
- packages/eslint-config/src/configs/jsonc.ts (1 hunks)
- packages/eslint-config/src/configs/mdx.ts (1 hunks)
- packages/eslint-config/src/configs/solid.ts (1 hunks)
- packages/eslint-config/src/configs/test.ts (1 hunks)
- packages/eslint-config/src/configs/toml.ts (1 hunks)
- packages/eslint-config/src/configs/typescript.ts (1 hunks)
- packages/eslint-config/src/configs/vue.ts (1 hunks)
- packages/eslint-config/src/configs/yaml.ts (1 hunks)
- packages/eslint-config/src/factory.ts (3 hunks)
- packages/eslint-config/src/types.ts (3 hunks)
- packages/eslint-config/src/utils.ts (2 hunks)
- packages/prettier-config/src/index.ts (1 hunks)
Additional comments not posted (1)
packages/eslint-config/src/configs/javascript.ts (1)
15-17: Verify the correctness of the return type change.The return type has been altered from
Promise<TypedFlatConfigItem[]>toPromise. Ensure that this change does not affect the downstream handling of the function's output.Run the following script to verify the function usage:
| export async function toml({ overrides }: OptionsOverrides = {}): Promise< | ||
| TypedFlatConfigItem[] | ||
| > { | ||
| export async function toml({ overrides }: OptionsOverrides = {}): Promise { |
There was a problem hiding this comment.
Revert the return type change.
The function still returns an array of configuration objects, so the original return type Promise<TypedFlatConfigItem[]> should be retained to maintain type safety and clarity.
Apply this diff to revert the return type change:
-export async function toml({ overrides }: OptionsOverrides = {}): Promise {
+export async function toml({ overrides }: OptionsOverrides = {}): Promise<TypedFlatConfigItem[]> {Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| export async function toml({ overrides }: OptionsOverrides = {}): Promise { | |
| export async function toml({ overrides }: OptionsOverrides = {}): Promise<TypedFlatConfigItem[]> { |
| }: OptionsHasTypeScript & OptionsOverrides = {}): Promise< | ||
| TypedFlatConfigItem[] | ||
| > { | ||
| }: OptionsHasTypeScript & OptionsOverrides = {}): Promise { |
There was a problem hiding this comment.
Revert the return type change.
The function still returns an array of configuration objects, so the original return type Promise<TypedFlatConfigItem[]> should be retained to maintain type safety and clarity.
Apply this diff to revert the return type change:
-export async function solid({ overrides, typescript }: OptionsHasTypeScript & OptionsOverrides = {}): Promise {
+export async function solid({ overrides, typescript }: OptionsHasTypeScript & OptionsOverrides = {}): Promise<TypedFlatConfigItem[]> {Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| }: OptionsHasTypeScript & OptionsOverrides = {}): Promise { | |
| export async function solid({ overrides, typescript }: OptionsHasTypeScript & OptionsOverrides = {}): Promise<TypedFlatConfigItem[]> { |
| export async function yaml({ overrides }: OptionsOverrides = {}): Promise< | ||
| TypedFlatConfigItem[] | ||
| > { | ||
| export async function yaml({ overrides }: OptionsOverrides = {}): Promise { |
There was a problem hiding this comment.
Revert the return type change.
The function still returns an array of configuration objects, so the original return type Promise<TypedFlatConfigItem[]> should be retained to maintain type safety and clarity.
Apply this diff to revert the return type change:
-export async function yaml({ overrides }: OptionsOverrides = {}): Promise {
+export async function yaml({ overrides }: OptionsOverrides = {}): Promise<TypedFlatConfigItem[]> {Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| export async function yaml({ overrides }: OptionsOverrides = {}): Promise { | |
| export async function yaml({ overrides }: OptionsOverrides = {}): Promise<TypedFlatConfigItem[]> { |
| import { interopDefault } from "../utils"; | ||
|
|
||
| export async function jsonc(): Promise<TypedFlatConfigItem[]> { | ||
| export async function jsonc(): Promise { |
There was a problem hiding this comment.
Revert to the more specific return type for better type safety.
The original return type Promise<TypedFlatConfigItem[]> provided more information about the structure of the returned data, which is beneficial for consumers of the function. Consider reverting to the original return type for better type safety and specificity.
Apply this diff to revert the return type:
-export async function jsonc(): Promise {
+export async function jsonc(): Promise<TypedFlatConfigItem[]> {Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| export async function jsonc(): Promise { | |
| export async function jsonc(): Promise<TypedFlatConfigItem[]> { |
| rules: Record<string, any>, | ||
| map: Record<string, string>, | ||
| ) => | ||
| export const renameRules = (rules: Record, map: Record) => |
There was a problem hiding this comment.
Revert to the more specific parameter types for better type safety.
The original parameter types Record<string, any> and Record<string, string> provided more information about the expected structure of the input data, which is beneficial for consumers of the function. Consider reverting to the original parameter types for better type safety and specificity.
Apply this diff to revert the parameter types:
-export const renameRules = (rules: Record, map: Record) =>
+export const renameRules = (rules: Record<string, any>, map: Record<string, string>) =>Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| export const renameRules = (rules: Record, map: Record) => | |
| export const renameRules = (rules: Record<string, any>, map: Record<string, string>) => |
| } | ||
|
|
||
| export type ResolvedOptions<T> = T extends boolean ? never : NonNullable<T>; | ||
| export type ResolvedOptions<T> = T extends boolean ? never : NonNullable; |
There was a problem hiding this comment.
Revert the type change to maintain type specificity.
The type ResolvedOptions<T> has been changed to ResolvedOptions. This removes the generic type parameter, reducing type specificity and potentially impacting type resolution in contexts where ResolvedOptions is utilized. Revert the change to maintain type specificity.
-export type ResolvedOptions<T> = T extends boolean ? never : NonNullable;
+export type ResolvedOptions<T> = T extends boolean ? never : NonNullable<T>;
): ResolvedOptions =>
): ResolvedOptions<Options[K]> =>Also applies to: 210-210
| }, | ||
| }, | ||
| ] satisfies (MaybeArray<TypedFlatConfigItem> | boolean)[] | ||
| ] satisfies (MaybeArray | boolean)[] |
There was a problem hiding this comment.
Maintain type specificity in type assertion.
Changing the type assertion from (MaybeArray<TypedFlatConfigItem> | boolean)[] to (MaybeArray | boolean)[] reduces type specificity and may lead to less predictable behavior in type-checking scenarios. Consider maintaining the original type assertion for better type safety.
Apply this diff to maintain type specificity:
-] satisfies (MaybeArray | boolean)[]
+] satisfies (MaybeArray<TypedFlatConfigItem> | boolean)[]Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| ] satisfies (MaybeArray | boolean)[] | |
| ] satisfies (MaybeArray<TypedFlatConfigItem> | boolean)[] |
| export async function formatting( | ||
| options?: Options, | ||
| ): Promise<TypedFlatConfigItem[]> { | ||
| export async function formatting(options?: Options): Promise { |
There was a problem hiding this comment.
Maintain type specificity in the function return type.
Changing the return type from Promise<TypedFlatConfigItem[]> to Promise reduces type specificity and may lead to less predictable behavior in type-checking scenarios. Consider maintaining the original return type for better type safety.
Apply this diff to maintain type specificity:
-export async function formatting(options?: Options): Promise {
+export async function formatting(options?: Options): Promise<TypedFlatConfigItem[]> {Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| export async function formatting(options?: Options): Promise { | |
| export async function formatting(options?: Options): Promise<TypedFlatConfigItem[]> { |
| }: OptionsHasTypeScript & OptionsOverrides = {}): Promise< | ||
| TypedFlatConfigItem[] | ||
| > { | ||
| }: OptionsHasTypeScript & OptionsOverrides = {}): Promise { |
There was a problem hiding this comment.
Maintain type specificity in the function return type.
Changing the return type from Promise<TypedFlatConfigItem[]> to Promise reduces type specificity and may lead to less predictable behavior in type-checking scenarios. Consider maintaining the original return type for better type safety.
Apply this diff to maintain type specificity:
}: OptionsHasTypeScript & OptionsOverrides = {}): Promise {
+}: OptionsHasTypeScript & OptionsOverrides = {}): Promise<TypedFlatConfigItem[]> {Committable suggestion was skipped due to low confidence.
| }: OptionsTypeScriptParserOptions & | ||
| OptionsComponentExts & | ||
| OptionsOverrides = {}): Promise<TypedFlatConfigItem[]> { | ||
| OptionsOverrides = {}): Promise { |
There was a problem hiding this comment.
Maintain type specificity in the function return type.
Changing the return type from Promise<TypedFlatConfigItem[]> to Promise reduces type specificity and may lead to less predictable behavior in type-checking scenarios. Consider maintaining the original return type for better type safety.
Apply this diff to maintain type specificity:
OptionsOverrides = {}): Promise {
+ OptionsOverrides = {}): Promise<TypedFlatConfigItem[]> {Committable suggestion was skipped due to low confidence.
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Autoclosing SkippedThis PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error. |
renovate
Bot
changed the title
This PR contains the following updates:
0.14.0->0.14.1Release Notes
withastro/prettier-plugin-astro (prettier-plugin-astro)
v0.14.1Compare Source
Patch Changes
7282bcb: Fixes an issue where style and script tags would sometimes get moved to other tagsConfiguration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
Refactor