fix: add unsafe code guardrails#54
Merged
rickcrawford merged 1 commit intomainfrom May 6, 2026
Merged
Conversation
cc63cf3 to
752a4af
Compare
Forbid unsafe in crates that do not require it and document the vault crate's explicit zeroization exception so future unsafe drift fails at compile time. Co-authored-by: Cursor <cursoragent@cursor.com>
752a4af to
9f0a913
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
#![forbid(unsafe_code)]to crate roots that do not need unsafe.#![allow(unsafe_code)]and inline justification forsbproxy-vault, where volatile zeroization intentionally uses unsafe.Test plan
cargo fmt --all -- --checkcargo build --workspacecargo check --workspace --all-targetsMade with Cursor