Skip to content

fix: emit webhook delivery headers#59

Merged
rickcrawford merged 1 commit intomainfrom
fix/wor-88-webhook-headers
May 6, 2026
Merged

fix: emit webhook delivery headers#59
rickcrawford merged 1 commit intomainfrom
fix/wor-88-webhook-headers

Conversation

@rickcrawford
Copy link
Copy Markdown
Contributor

Summary

  • Closes WOR-88 by adding Sbproxy-Subscription-Id, Sbproxy-Delivery-Id, and Sbproxy-Attempt to outbound webhook delivery attempts.
  • Adds a stable subscription_id field to Subscription and generates a fresh delivery ULID for every retry attempt.
  • Extends notifier tests and updates the changelog.

Test plan

  • RED: cargo test -p sbproxy-observe retry_then_deadletter failed because Sbproxy-Attempt was missing
  • GREEN: cargo test -p sbproxy-observe retry_then_deadletter
  • cargo test -p sbproxy-observe notify::tests::dispatch_signs_with_ed25519
  • cargo test -p sbproxy-observe --lib
  • cargo fmt --all -- --check
  • git diff --check
  • IDE lints: no errors for crates/sbproxy-observe/src/notify.rs

Made with Cursor

@rickcrawford rickcrawford force-pushed the fix/wor-88-webhook-headers branch 4 times, most recently from 7b79ed9 to 1112df2 Compare May 6, 2026 07:38
Add subscription, delivery, and attempt headers to outbound webhook attempts so customers can distinguish subscriptions and retry deliveries.

Co-authored-by: Cursor <cursoragent@cursor.com>
@rickcrawford rickcrawford force-pushed the fix/wor-88-webhook-headers branch from 1112df2 to dca4950 Compare May 6, 2026 07:58
@rickcrawford rickcrawford merged commit 5f1e720 into main May 6, 2026
8 checks passed
@rickcrawford rickcrawford deleted the fix/wor-88-webhook-headers branch May 6, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant