Skip to content

feat: add hostname cardinality cap override#60

Merged
rickcrawford merged 1 commit intomainfrom
feat/wor-89-hostname-cap
May 6, 2026
Merged

feat: add hostname cardinality cap override#60
rickcrawford merged 1 commit intomainfrom
feat/wor-89-hostname-cap

Conversation

@rickcrawford
Copy link
Copy Markdown
Contributor

Summary

  • Closes WOR-89 by adding proxy.metrics.cardinality.hostname_cap for the public hostname label budget.
  • Wires the metrics config into the runtime cardinality limiter before request metrics are recorded.
  • Unignores the hostname overflow e2e regression and documents the new config knob.

Test plan

  • RED: cargo build -p sbproxy && cargo test -p sbproxy-e2e --test metrics_per_agent cardinality_overflow_emits_sentinel_and_increments_demotion_counter failed because the lowered hostname cap was not applied
  • GREEN: cargo test -p sbproxy-observe hostname_cap_override_wins_over_adr_budget
  • cargo test -p sbproxy-observe record_request_with_labels_stamps_agent_dimensions
  • cargo test -p sbproxy-config --lib
  • cargo build -p sbproxy && cargo test -p sbproxy-e2e --test metrics_per_agent cardinality_overflow_emits_sentinel_and_increments_demotion_counter
  • cargo test -p sbproxy-observe --lib
  • cargo fmt --all -- --check
  • git diff --check
  • IDE lints: no errors for edited files

Made with Cursor

@rickcrawford rickcrawford force-pushed the feat/wor-89-hostname-cap branch 3 times, most recently from acdc709 to d1ca631 Compare May 6, 2026 07:39
Allow proxy metrics config to lower the hostname label budget independently, making overflow behavior deterministic for tests and tighter multi-tenant deployments.

Co-authored-by: Cursor <cursoragent@cursor.com>
@rickcrawford rickcrawford force-pushed the feat/wor-89-hostname-cap branch from d1ca631 to 7062269 Compare May 6, 2026 07:59
@rickcrawford rickcrawford merged commit afb65c2 into main May 6, 2026
8 checks passed
@rickcrawford rickcrawford deleted the feat/wor-89-hostname-cap branch May 6, 2026 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant