feat: add hostname cardinality cap override#60
Merged
rickcrawford merged 1 commit intomainfrom May 6, 2026
Merged
Conversation
acdc709 to
d1ca631
Compare
Allow proxy metrics config to lower the hostname label budget independently, making overflow behavior deterministic for tests and tighter multi-tenant deployments. Co-authored-by: Cursor <cursoragent@cursor.com>
d1ca631 to
7062269
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
proxy.metrics.cardinality.hostname_capfor the publichostnamelabel budget.Test plan
cargo build -p sbproxy && cargo test -p sbproxy-e2e --test metrics_per_agent cardinality_overflow_emits_sentinel_and_increments_demotion_counterfailed because the lowered hostname cap was not appliedcargo test -p sbproxy-observe hostname_cap_override_wins_over_adr_budgetcargo test -p sbproxy-observe record_request_with_labels_stamps_agent_dimensionscargo test -p sbproxy-config --libcargo build -p sbproxy && cargo test -p sbproxy-e2e --test metrics_per_agent cardinality_overflow_emits_sentinel_and_increments_demotion_countercargo test -p sbproxy-observe --libcargo fmt --all -- --checkgit diff --checkMade with Cursor