Open
Conversation
soaubier
force-pushed
the
radar_plot
branch
3 times, most recently
from
0feee77 to
5edcf37
Compare
Collaborator
|
Threshold spinbox maximum value must be a lot greater than 99. If the threshold checkbox is not checked, we should hide the threshold widgets (line type and value), no? Threshold checkbox need a first upper letter. |
Djedouas
reviewed
Mar 28, 2025
Collaborator
There was a problem hiding this comment.
I think we need something more recognizable: not filled and with more than 3 points.
See this example
DataPlotly/core/plot_types/radar.py
Outdated
| if settings.properties['threshold'] is True : | ||
| colors_list.append('#000000') | ||
| settings.y.append([settings.properties['threshold_value']] * len(settings.y_radar_values[0])) | ||
| settings.y_radar_labels.append('threshold') |
Collaborator
There was a problem hiding this comment.
We might want to translate this label
Comment on lines
674
to
677
| self.marker_types = OrderedDict([ | ||
| (self.tr('Points'), 'markers'), | ||
| (self.tr('Lines'), 'lines'), | ||
| (self.tr('Points'), 'markers'), | ||
| (self.tr('Points and Lines'), 'lines+markers') |
Collaborator
There was a problem hiding this comment.
Why this change of order?
| self.line_combo.clear() | ||
| for k, v in self.line_types.items(): | ||
| self.line_type_threshold.clear() | ||
| for k, v in self.line_types2.items(): |
Collaborator
There was a problem hiding this comment.
Why changing from line_types to line_types2?
Co-authored-by: Jacky Volpes <34267385+Djedouas@users.noreply.github.com>
soaubier
commented
Apr 15, 2025
line type and combo box are now decorrelated
Refresh the UI according to Points, Line, Points and Lines marker type not only when marker type changes, but also when the plot type changes (to be correctly initialized).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.