Skip to content

Fix update#24

Open
Geesu wants to merge 2 commits into
soccernee:masterfrom
Geesu:fix/update
Open

Fix update#24
Geesu wants to merge 2 commits into
soccernee:masterfrom
Geesu:fix/update

Conversation

@Geesu
Copy link
Copy Markdown

@Geesu Geesu commented May 18, 2018

According to the documentation you shouldn't send the entire object, only the fields you care about:

screen shot 2018-05-18 at 11 49 27 am

Fixes #23

@Geesu Geesu mentioned this pull request May 18, 2018
@alydersen
Copy link
Copy Markdown

Hi guys,
I would really appreciate if you could merge this branch - the error is preventing me from using the whole update function.

@Geesu
Copy link
Copy Markdown
Author

Geesu commented May 23, 2018

You can just reference my branch in your gemfile if you'd like, or fork it.

@soccernee
Copy link
Copy Markdown
Owner

As mentioned in issue #23, this is a good step in the right direction, but it does constitute a breaking change. The update method currently supports making updates to the entity itself, and then passing it to the update method.

This change would only allow updates to be made by passing in an attributes hash of the updated values. What we could do, though, is if an attributes hash is supplied to the update method, only pass that up to the PW API. When such a hash does not exist, the update method should fall back to passing up the entity.

What do you think of that, @Geesu?

@Geesu
Copy link
Copy Markdown
Author

Geesu commented Jun 6, 2018

Yea that makes complete sense. I'll update this PR shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants