Preserve absolute Ruby constant references - #8
Merged
Conversation
samuel-williams-shopify
force-pushed
the
preserve-absolute-superclass
branch
from
August 15, 2026 22:32
462a914 to
3fb1047
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decode currently loses the leading
::when parsing nested Ruby constant references. This makes an absolute superclass such as::Parentindistinguishable from the relativeParent.Preserve the leading
::innested_name_for, while retaining the existing representation for qualified constants such asMy::Parent.This is needed to resolve superclass references correctly for socketry/utopia-project#3.
Tests cover both qualified and absolute superclass names.
Checks:
bundle exec bake testbundle exec rubocop