Serialize relative URLs explicitly - #20
Merged
Merged
Conversation
samuel-williams-shopify
force-pushed
the
explicit-relative-serialization
branch
from
August 15, 2026 00:47
2e4b5f4 to
3a521dd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
explicit:from relative path calculation to URL serializationto_s(explicit: true)andappend(..., explicit: true)for relative URLs and referencesexplicit:fromPath.relativeandRelative#relative_toThere are two serialization contexts:
In the second context,
explicit: trueadds./to otherwise ambiguous same-directory references. Applying this at serialization preserves the distinction after URL composition and normalization.This revises the API introduced in v0.17.0.
Testing
BUNDLE_WITHOUT=maintenance bundle exec bake test(390 tests, 571 assertions)BUNDLE_WITHOUT=maintenance bundle exec rubocop