Skip to content

Fix Windows extension feature detection.#4

Merged
samuel-williams-shopify merged 1 commit into
mainfrom
fix-windows-coverage-build
Jun 15, 2026
Merged

Fix Windows extension feature detection.#4
samuel-williams-shopify merged 1 commit into
mainfrom
fix-windows-coverage-build

Conversation

@samuel-williams-shopify

@samuel-williams-shopify samuel-williams-shopify commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add Windows to the main CI test matrix
  • use have_func with an actual rb_tracearg_instruction_sequence call expression so mkmf rejects missing header declarations
  • avoid an unused tracer variable warning in the raw hook build path
  • add an ## Unreleased release note for the Windows native extension build fix
  • fall back to the TracePoint object API when Ruby exposes the symbol but not the C header declaration

Notes

The Windows failure happened because probing the bare symbol can succeed when the symbol is linkable even if ruby/debug.h does not declare it. The call-expression form fails on implicit declarations and still defines HAVE_RB_TRACEARG_INSTRUCTION_SEQUENCE when supported.

ext/extconf.h is generated by create_header; it is already ignored by .gitignore and remains untracked.

Validation

  • bundle exec bake test
  • bundle exec rubocop

@samuel-williams-shopify samuel-williams-shopify force-pushed the fix-windows-coverage-build branch 2 times, most recently from 03af1f6 to 7b78849 Compare June 15, 2026 08:58
@samuel-williams-shopify samuel-williams-shopify changed the title Fix Windows extension feature detection Fix Windows extension feature detection. Jun 15, 2026
@samuel-williams-shopify samuel-williams-shopify merged commit 6914df8 into main Jun 15, 2026
30 of 34 checks passed
@samuel-williams-shopify samuel-williams-shopify deleted the fix-windows-coverage-build branch June 15, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant