Skip to content

Cover controller layer contracts. - #80

Merged
samuel-williams-shopify merged 2 commits into
mainfrom
cover-controller-layer
Aug 17, 2026
Merged

Cover controller layer contracts.#80
samuel-williams-shopify merged 2 commits into
mainfrom
cover-controller-layer

Conversation

@samuel-williams-shopify

Copy link
Copy Markdown
Contributor

Adds focused coverage for the controller layer:

  • verifies action equality, inspection, and fallback dispatch
  • verifies configured controller metadata and downstream delegation
  • verifies missing controller variables raise KeyError

This covers the 12 previously unexecuted lines in Controller::Actions, Controller::Base, and Controller::Variables, increasing projected coverage from 96.65% to 97.12%.

The focused tests and RuboCop checks pass. The complete local test task remains obstructed by stale native extensions in vendor/bundle; CI provides the clean full-suite result.

Assisted-By: devx/cbdeae41-9308-4071-ad53-58cd92db2946
Assisted-By: devx/cbdeae41-9308-4071-ad53-58cd92db2946
@samuel-williams-shopify
samuel-williams-shopify merged commit 5666ddb into main Aug 17, 2026
34 of 36 checks passed
@samuel-williams-shopify
samuel-williams-shopify deleted the cover-controller-layer branch August 17, 2026 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant