Fix calculating bounds when sticky is in a custom and already scrolled container#23
Open
jtomaszewski wants to merge 1 commit intosoenkekluth:masterfrom
Open
Fix calculating bounds when sticky is in a custom and already scrolled container#23jtomaszewski wants to merge 1 commit intosoenkekluth:masterfrom
jtomaszewski wants to merge 1 commit intosoenkekluth:masterfrom
Conversation
…d scroll container
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It took me half a day to find the issue and another hour to find the fix. But I got it.
The bug appears when sticky element is in a nested scroll container, that is already scrolled. (That is: Sticky component is being initialized when its non-window scroll container is already scrolled; Or when window is resized while that non-window scroll container is already scrolled.)
This fix fixes it.