Skip to content

Conversation

@hugtalbot
Copy link
Contributor

@hugtalbot hugtalbot commented Jan 28, 2026

  • Disable RegisterObject as it should have been
  • Remove data J, m_constraintMatrix to be used instead
  • Postpone removal (in TriangleSetGeometryAlgorithms) to give @epernod time to work on it
  • Fix error on lifecycle disabling version in Prism

Possibly to merge before #5888 and #5892

[with-all-tests]


By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).


Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@hugtalbot hugtalbot added pr: status to review To notify reviewers to review this pull-request pr: clean Cleaning the code labels Jan 28, 2026
@fredroy
Copy link
Contributor

fredroy commented Jan 28, 2026

  • Disable RegisterObject as it should have been

Are you sure you want to disable this ? 🫢
I mean, the SofaCUDA one has been just converted so... 🫠

I would have at least postpone for 6 months (a release) more

@hugtalbot
Copy link
Contributor Author

We can 👍
It's the second item where we would need to postpone the disabling date. I think we should pay more attention to these dates when the initial PR is open (note to myself)

@hugtalbot
Copy link
Contributor Author

done @fredroy

@hugtalbot hugtalbot added this to the v26.06 milestone Jan 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr: clean Cleaning the code pr: status to review To notify reviewers to review this pull-request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants