[Visual] Fix crash when texturename is not leading to a valid texture file#6075
Open
epernod wants to merge 2 commits into
Open
[Visual] Fix crash when texturename is not leading to a valid texture file#6075epernod wants to merge 2 commits into
epernod wants to merge 2 commits into
Conversation
epernod
added
pr: fix
hugtalbot
reviewed
Apr 9, 2026
epernod
commented
Apr 9, 2026
hugtalbot
approved these changes
Apr 10, 2026
alxbilger
requested changes
Apr 16, 2026
| std::string textureFilename = d_texturename.getFullPath(); | ||
| if (sofa::helper::system::DataRepository.findFile(textureFilename)) | ||
| { | ||
| loadTexture(d_texturename.getFullPath()); |
Contributor
There was a problem hiding this comment.
Suggested change
| loadTexture(d_texturename.getFullPath()); | |
| loadTexture(textureFilename); |
Contributor
There was a problem hiding this comment.
findFile return false when it is a full path, so this check is indeed wrong
epernod
added
pr: status wip
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
everything is in the title, if d_texturename is not empty but the file doesn't exists there is some crash even if ImageIO is also doing the check...
By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).
Reviewers will merge this pull-request only if