3.1.2 zhile#454
Open
kailll wants to merge 18 commits intosofastack:3.xfrom
Open
Conversation
Bumps [junit](https://github.com/junit-team/junit4) from 4.12 to 4.13.1. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.12.md) - [Commits](junit-team/junit4@r4.12...r4.13.1) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Khotyn Huang <hting1@gmail.com>
Optimize imports of SOFATracer, such a lot of unused import. close sofastack#428
* Add functional support and test cases
* support logging.file.path
* Speed up test case by removing sleep code
|
Hi @kailll, welcome to SOFAStack community, Please sign Contributor License Agreement! After you signed CLA, we will automatically sync the status of this pull request in 3 minutes. |
xzchaoo
reviewed
Oct 10, 2021
| if("true".equals(SofaTracerConfiguration.getProperty(SofaTracerConfiguration.FILL_MINUTE_SWITCH))){ | ||
| initialDelay = DateUtils.diffNextMinute(new Date()); | ||
| } | ||
| executor.scheduleAtFixedRate(new StatReporterPrinter(), initialDelay, cycleTime, TimeUnit.SECONDS); |
Contributor
There was a problem hiding this comment.
此处initialDelay的单位是mills, 而scheduleAtFixedRate要求initialDelay和interval的单位由第4个参数指定.
added 2 commits
October 11, 2021 14:08
Contributor
|
@kailll pls rebase your brach，there are to much irrelevant commit record |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
bug fix
Modification:
修复采样率传递问题
stat 时间段整分钟
dataSource 部分enpoint为空
dataSource pg读写url解析
dataSource resultCode一直是N的bug
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.