Skip to content

[#494] Refactor UploadedFile into upload collaborators#495

Merged
armanist merged 1 commit intosoftberg:masterfrom
armanist:feature/494-uploadedfile-refactor
May 1, 2026
Merged

[#494] Refactor UploadedFile into upload collaborators#495
armanist merged 1 commit intosoftberg:masterfrom
armanist:feature/494-uploadedfile-refactor

Conversation

@armanist
Copy link
Copy Markdown
Member

@armanist armanist commented May 1, 2026

Closes #494

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 1, 2026

Warning

Rate limit exceeded

@armanist has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 6 minutes and 1 second before requesting another review.

To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 660a90ac-94d5-4f17-995b-a12b9e2d1d0d

📥 Commits

Reviewing files that changed from the base of the PR and between 0b11376 and d171b5f.

📒 Files selected for processing (9)
  • src/Module/Templates/DemoWeb/src/Views/partials/footer.php.tpl
  • src/Storage/UploadedFile.php
  • src/Storage/Uploads/UploadConfigProvider.php
  • src/Storage/Uploads/UploadPolicy.php
  • src/Storage/Uploads/UploadStorage.php
  • tests/Unit/Storage/UploadedFileTest.php
  • tests/Unit/Storage/Uploads/UploadConfigProviderTest.php
  • tests/Unit/Storage/Uploads/UploadPolicyTest.php
  • tests/Unit/Storage/Uploads/UploadStorageTest.php
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
Review rate limit: 0/1 reviews remaining, refill in 6 minutes and 1 second.

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 1, 2026

Codecov Report

❌ Patch coverage is 94.33962% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.87%. Comparing base (0b11376) to head (d171b5f).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/Storage/Uploads/UploadConfigProvider.php 85.71% 2 Missing ⚠️
src/Storage/Uploads/UploadStorage.php 87.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #495      +/-   ##
============================================
+ Coverage     90.73%   90.87%   +0.14%     
- Complexity     2917     2926       +9     
============================================
  Files           252      255       +3     
  Lines          7683     7703      +20     
============================================
+ Hits           6971     7000      +29     
+ Misses          712      703       -9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@armanist armanist added enhancement New feature or request refactoring labels May 1, 2026
@armanist armanist added this to the 3.0.0 milestone May 1, 2026
@armanist armanist requested a review from andrey-smaelov May 1, 2026 17:14
@armanist armanist merged commit e8bcbb4 into softberg:master May 1, 2026
7 checks passed
@armanist armanist deleted the feature/494-uploadedfile-refactor branch May 1, 2026 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor UploadedFile responsibilities into focused upload collaborators

2 participants