Apply default guard to ESI section name for consistency with AJAX path#126
Merged
Apply default guard to ESI section name for consistency with AJAX path#126
Conversation
Co-authored-by: javihgil <2581053+javihgil@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update admin version info sections based on feedback
Apply default guard to ESI section name for consistency with AJAX path
Feb 24, 2026
Base automatically changed from
fix-admin-bug-with-sections-in-version-info
to
5.5
February 25, 2026 07:31
javihgil
added a commit
that referenced
this pull request
Mar 10, 2026
#126) * Fix admin bug with sections in version info * Initial plan * Add default guard to ESI section name to match AJAX branch Co-authored-by: javihgil <2581053+javihgil@users.noreply.github.com> --------- Co-authored-by: Javi H. Gil <javihgil@softspring.es> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: javihgil <2581053+javihgil@users.noreply.github.com> Co-authored-by: Javi H. Gil <javihgil@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses feedback on #125 where the ESI section rendering lacked the
|default('N/A')guard present in the AJAX path, creating inconsistent behavior and potential Twig undefined-variable errors.Changes
|default('N/A')toesiCall.processed.section_namein the ESI branch to match the existing AJAX branch guardBefore (ESI path):
Section {{ esiCall.processed.section_name }}After (ESI path):
Section {{ esiCall.processed.section_name|default('N/A') }}Both ESI and AJAX code paths now handle missing
section_nameidentically.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.