treeshake: prepare for otp - #716
Open
jgonet wants to merge 2 commits into
Open
Conversation
jgonet
commented
Jul 29, 2026
jgonet
commented
Member
- avoids adding helper when it's not needed.
- sidesteps the problem of otp packager not handling builtin apps by providing behaviour information from host (this has its drawbacks, maybe we should redesign packager in the future).
We should avoid copying them when we don't use it; OTP packager script works on premise that all apps gathered can resolve to actual apps in the project.
Treeshaker doesn't see apps outside of passed ones. OTP packager omits builtin apps for now, so core behaviours (such as gen_server) are not tracked. We take them from the host; OTP packager already checks for major version compat between BEAM coming from Popcorn and host one.
mat-hek
reviewed
Jul 30, 2026
| do: callbacks | ||
|
|
||
| defp behaviour_callbacks(nil, _module, behaviour) do | ||
| with {:module, ^behaviour} <- Code.ensure_loaded(behaviour), |
Contributor
There was a problem hiding this comment.
Don't we scan all the beam files that can be loaded? If not, we probably should
Comment on lines
+220
to
+221
| stub_functions = Map.get(opts, :stub_removed_functions, false) | ||
| stub_modules = Map.get(opts, :stub_removed_modules, false) |
Contributor
There was a problem hiding this comment.
Now we set the default here and in the shaker. Let's do that once, in parse_opts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.