test: add maestro-runner - #714
Open
kacperzolkiewski wants to merge 15 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Refactors the repo’s Maestro-based e2e suite to run via maestro-runner (DeviceLab driver on Android, default on iOS) and updates flows/subflows to be more runner-friendly and screenshot-stable.
Changes:
- Switch
.maestro/scripts/run-tests.shfrommaestrotomaestro-runner, including driver selection and updated tag-filter handling. - Introduce a shared
.maestro/subflows/input_text.yamland update many flows to use it (plus additionalwaitForAnimationToEnd/ swipe adjustments). - Minor example-app UI tweaks intended to stabilize e2e interactions/screenshots (cursor/selection styling).
Reviewed changes
Copilot reviewed 48 out of 170 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/example/src/screens/TestScreen.tsx | Adjusts editor cursor/selection styling and adds tintColor in the example screen. |
| .maestro/subflows/input_text.yaml | New cross-platform text-input helper subflow. |
| .maestro/scripts/run-tests.sh | Runs flows through maestro-runner, selects Android driver, and updates invocation/logging. |
| .maestro/enrichedText/subflows/set_enriched_text_value.yaml | Adds waits to ensure modal dismissal before proceeding. |
| .maestro/enrichedText/subflows/run_ellipsize_case.yaml | Normalizes quoting/formatting and adds an animation wait before screenshots. |
| .maestro/enrichedText/flows/paragraph_styles_display.yaml | Flattens HTML value, replaces scroll with swipe, adds waits for stability. |
| .maestro/enrichedText/flows/mention_press.yaml | Adds wait before taking/asserting screenshot. |
| .maestro/enrichedText/flows/link_press.yaml | Adds wait before taking/asserting screenshot. |
| .maestro/enrichedText/flows/inline_styles_display.yaml | Flattens/quotes HTML value to a single line. |
| .maestro/enrichedText/flows/font_scaling.yaml | Replaces scroll with swipe and adds wait. |
| .maestro/enrichedText/flows/empty_list_elements_display.yaml | Flattens HTML value to a single-line scalar. |
| .maestro/enrichedText/flows/ellipsize_mode.yaml | Normalizes quoting for HTML value. |
| .maestro/enrichedText/flows/custom_styles_display.yaml | Adds an intentional delay step before screenshot. |
| .maestro/enrichedText/flows/alignment_visual.yaml | Flattens/quotes HTML value to a single line. |
| .maestro/enrichedInput/subflows/set_editor_value.yaml | Adds waits to ensure modal dismissal before proceeding. |
| .maestro/enrichedInput/subflows/insert_link.yaml | Routes text entry through the new input_text subflow. |
| .maestro/enrichedInput/subflows/insert_image.yaml | Simplifies/normalizes the image insert subflow steps and quoting. |
| .maestro/enrichedInput/subflows/capture_or_assert_fullscreen_screenshot.yaml | Adds a wait before capturing/asserting screenshot. |
| .maestro/enrichedInput/flows/scrolling_with_paragraph_styles.yaml | Uses input_text subflow for typing and normalizes quoting/paths. |
| .maestro/enrichedInput/flows/scrolling_after_typing.yaml | Uses input_text subflow for typing, adjusts blur/waits and screenshot timing. |
| .maestro/enrichedInput/flows/paragraph_styles_no_crash.yaml | Uses input_text subflow for typing. |
| .maestro/enrichedInput/flows/paragraph_styles_lists_visual.yaml | Uses input_text subflow for typing. |
| .maestro/enrichedInput/flows/paragraph_styles_headings_visual.yaml | Uses input_text subflow for typing and normalizes quoting/paths. |
| .maestro/enrichedInput/flows/paragraph_styles_blocks_visual.yaml | Uses input_text subflow for typing. |
| .maestro/enrichedInput/flows/paragraph_styles_alignment_visual.yaml | Uses input_text subflow for typing. |
| .maestro/enrichedInput/flows/paragraph_style_toggle.yaml | Uses input_text subflow for typing. |
| .maestro/enrichedInput/flows/paragraph_style_removal.yaml | Uses input_text subflow for typing. |
| .maestro/enrichedInput/flows/ordered_list_renumbering.yaml | Uses input_text subflow for typing. |
| .maestro/enrichedInput/flows/mention_popup_closing_on_cursor_travel.yaml | Switches setup to use set_editor_value and normalizes quoting/paths. |
| .maestro/enrichedInput/flows/list_newline_insertion.yaml | Switches platform-specific typing to the input_text subflow. |
| .maestro/enrichedInput/flows/links_visual.yaml | Uses input_text subflow and adds platform-specific selection gestures. |
| .maestro/enrichedInput/flows/link_not_extended.yaml | Uses input_text subflow for typing. |
| .maestro/enrichedInput/flows/line_overlapping.yaml | Uses input_text subflow for typing. |
| .maestro/enrichedInput/flows/inline_styles_visual.yaml | Uses input_text subflow for typing. |
| .maestro/enrichedInput/flows/inline_styles_survive_block_toggle.yaml | Uses input_text subflow for typing. |
| .maestro/enrichedInput/flows/inline_styles_removal.yaml | Uses input_text subflow for typing. |
| .maestro/enrichedInput/flows/inline_code_paste_into_codeblock.yaml | Reworks selection/copy/paste gestures for iOS vs Android and uses input_text. |
| .maestro/enrichedInput/flows/inline_code_blocking_styles.yaml | Uses input_text subflow for typing. |
| .maestro/enrichedInput/flows/image_position_stability.yaml | Disables a currently-broken runner path with a TODO and issue link. |
| .maestro/enrichedInput/flows/image_inside_list_parsing.yaml | Adds an intentional delay step before screenshot. |
| .maestro/enrichedInput/flows/html_link_not_extended.yaml | Uses input_text subflow for typing. |
| .maestro/enrichedInput/flows/font_scaling.yaml | Uses input_text subflow for typing. |
| .maestro/enrichedInput/flows/extending_paragraph_style_on_paste_after_cut.yaml | Uses input_text and adds platform-specific selection gestures; normalizes quoting. |
| .maestro/enrichedInput/flows/extending_paragraph_style_on_paste_after_copy.yaml | Uses input_text and adds platform-specific selection gestures; normalizes quoting. |
| .maestro/enrichedInput/flows/conflicting_paragraph_merge.yaml | Uses input_text subflow for typing. |
| .maestro/enrichedInput/flows/codeblock_style_blocking.yaml | Uses input_text subflow for typing. |
| .maestro/enrichedInput/flows/codeblock_no_link_detection.yaml | Uses input_text subflow for typing. |
| .maestro/enrichedInput/flows/checkbox_toggle.yaml | Uses input_text subflow for typing. |
| .gitignore | Ignores reports/ directory. |
Suppressed comments (2)
.maestro/enrichedInput/flows/list_newline_insertion.yaml:34
- Same as above: use the same
when.platformcasing (iOS) as the rest of the Maestro flows to avoid a non-matching condition.
when:
platform: ios
commands:
.maestro/scripts/run-tests.sh:170
- This message still says "maestro" even though the script now runs
maestro-runner, which can be confusing when debugging CI logs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…ftware-mansion/react-native-enriched into @kacperzolkiewski/feat-maestro-runner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Refactor e2e tests to use
maestro-runnerTest Plan
Screenshots / Videos
Compatibility
Checklist