fix: off-by-one in Kokoro::synthesize voice index causes crash#941
Open
yocontra wants to merge 1 commit intosoftware-mansion:mainfrom
Open
fix: off-by-one in Kokoro::synthesize voice index causes crash#941yocontra wants to merge 1 commit intosoftware-mansion:mainfrom
yocontra wants to merge 1 commit intosoftware-mansion:mainfrom
Conversation
`voice_` is `std::array<..., kMaxInputTokens>` (128 elements, valid indices 0–127). When `noTokens` equals `kMaxInputTokens` (128) and `phonemes.size() - 1 >= 128`, `voiceID` becomes 128 — one past the end — triggering an out-of-bounds access and aborting on the `RN_ET_Worker0` thread. Fix: cap `voiceID` at `noTokens - 1` instead of `noTokens`.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Larger fix that includes this here: #943)
Broke this out in case you don't want the other change. If you merge #943 you can close this one.
Kokoro::synthesizecomputesvoiceIDas:voice_isstd::array<std::array<float, kVoiceRefSize>, kMaxInputTokens>— 128 elements with valid indices 0–127.When
noTokensequalscontext_.inputTokensLimit(which can bekMaxInputTokens= 128), andphonemes.size() - 1 >= 128,voiceIDbecomes 128 — one past the end of the array. This causes an out-of-bounds access that aborts on theRN_ET_Worker0thread.Crash stack trace
Fix
Cap
voiceIDatnoTokens - 1instead ofnoTokens:This keeps the index within the valid range of
voice_.