Skip to content

chore: Disable prebuilt RN core for FabricExample#3552

Merged
kmichalikk merged 2 commits into
mainfrom
@kmichalikk/disable-prebuild-084
Jan 20, 2026
Merged

chore: Disable prebuilt RN core for FabricExample#3552
kmichalikk merged 2 commits into
mainfrom
@kmichalikk/disable-prebuild-084

Conversation

@kmichalikk

@kmichalikk kmichalikk commented Jan 20, 2026

Copy link
Copy Markdown
Contributor

Description

This PR overrides the new default for downloading prebuild binaries for RN core since 0.84. We need the source code for debugging in our Example app.

Relevant commit from RN: react/react-native#54895

Changes

Env vars: RCT_USE_PREBUILT_RNCORE is set to '0' in the Podfile.

From READMEs and comments:

- RCT_USE_PREBUILT_RNCORE: If set to 1, it will use the release tarball from Maven instead of building from source.

Test plan

Make sure FabricExample builds & the source code is available in XCode.

Checklist

n/a

  • Ensured that CI passes

@kmichalikk kmichalikk self-assigned this Jan 20, 2026
@kmichalikk kmichalikk requested a review from kkafar January 20, 2026 13:09
@kmichalikk kmichalikk changed the title chore: Disable prebuilt RN core chore: Disable prebuilt RN core for FabricExample Jan 20, 2026

@kkafar kkafar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Could you please check, what libraries exactly are prebuilded when the RCT_USE_RN_DEP is set to 1? In case it includes only libraries such as boost, DoubleConversion, fast_float, glog, etc., but nothing from react native core, then I think we should left it enabled. I don't recall ever patching / experimenting with these libraries.

@kmichalikk

Copy link
Copy Markdown
Contributor Author

I can see these are the libs you mentioned, so I'm not disabling the env

@kmichalikk kmichalikk requested a review from kkafar January 20, 2026 14:35

@kkafar kkafar left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good then. Thank you!

@kmichalikk kmichalikk merged commit c3681a7 into main Jan 20, 2026
5 checks passed
@kmichalikk kmichalikk deleted the @kmichalikk/disable-prebuild-084 branch January 20, 2026 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants