chore(test): add e2e test for test-tabs-system-item-ios scenario by LKuchno · Pull Request #4147 · software-mansion/react-native-screens

LKuchno · 2026-06-10T13:22:05Z

Description

This PR implements the Detox e2e test suite for the test-tabs-system-item-ios scenario, covering the systemItem prop on iOS tab bar items.

The test covers: static system item rendering, runtime systemItem cycling (favorites/history/search), title override cycling (custom/hidden/system), icon override cycling (custom SFSymbols vs. system fallback), and combinations of all three overrides. All test blocks are wrapped in describeIfiOS since this feature is iOS-only. The scenario.md is updated to reflect what is and isn't automated.

⚠️ Notes

The following are explicitly not automated (documented in scenario.md):

Validating icon vs. selectedIcon differences
Checking visual icon and label changes.
"Hidden title" is verified indirectly only; manual verification recommended
Steps 20-23 (orientation changes).

Closes https://github.com/software-mansion/react-native-screens-labs/issues/1410

Changes

E2E/Tabs: Add test-tabs-system-item-ios.e2e.ts - new Detox test suite
Test Screen: Add testID attributes to config state display labels and section headers; add tabBarItemTestID to both tab route configso enable reliable Detox targeting
Scenario Docs: Update scenario.md to replace "TBD" with the actual automation status, listing known gaps

…mitem, add new tab with systemitem and empty title prop - no title

…efinition to match route_cofig order

…ns into @lkuchno/test-tab-system-item-ios

…ns into @lkuchno/e2e-test-tab-system-item-ios

Copilot

Pull request overview

Adds an iOS-only Detox e2e test suite for the test-tabs-system-item-ios single-feature scenario to validate systemItem behavior and runtime overrides (systemItem/title/icon), and updates the scenario + screen to support stable test targeting.

Changes:

Added a new Detox e2e suite covering static rendering and runtime cycling/combination of systemItem, title overrides, and icon overrides.
Updated the test screen to expose stable testIDs for config state labels/section headers and tab bar items.
Updated scenario documentation to explicitly list what is and isn’t automated.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File	Description
FabricExample/e2e/single-feature-tests/tabs/test-tabs-system-item-ios.e2e.ts	New Detox suite for iOS `systemItem` tab bar behavior and overrides.
apps/src/tests/single-feature-tests/tabs/test-tabs-system-item-ios/index.tsx	Adds `testID`s for Detox targeting and tab bar item IDs; minor JSX change.
apps/src/tests/single-feature-tests/tabs/test-tabs-system-item-ios/scenario.md	Documents current automation coverage and known manual gaps.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+describeIfiOS('Tab Bar System Item', () => {
+  beforeAll(async () => {
+    await device.reloadReactNative();
+    await selectSingleFeatureTestsScreen('Tabs', 'test-tabs-system-item-ios');
+  });
+
+  describe('Static System Item tab', () => {
+    it('should display the tab bar with system item titles and icons', async () => {
+      await expect(element(by.type('UITabBar'))).toBeVisible();
+      await expect(element(by.text('Static System Item'))).toBeVisible();
+      await expect(element(by.id('bookmark-tab-item'))).toHaveLabel(
+        'Bookmarks',
+      );
+      await expect(element(by.id('custom-tab-item'))).toHaveLabel('Favorites');
+      await expect(
+        element(by.id('book.fill').and(by.label('bookmark'))).atIndex(0),
+      ).toExist();
+      await expect(
+        element(by.id('star.fill').and(by.label('favorite'))).atIndex(0),
+      ).toExist();
+    });
+
+    it('tab bar item icon and title should remain the same when switching between tabs', async () => {
+      await element(by.id('custom-tab-item')).tap();
+      await expect(element(by.text('Runtime Config'))).toBeVisible();
+      await expect(
+        element(by.id('book.fill').and(by.label('bookmark'))).atIndex(0),
+      ).toExist();
+      await expect(element(by.id('bookmark-tab-item'))).toHaveLabel(
+        'Bookmarks',
+      );
+
+      await element(by.id('bookmark-tab-item')).tap();
+      await expect(element(by.text('Static System Item'))).toBeVisible();
+      await expect(
+        element(by.id('book.fill').and(by.label('bookmark'))).atIndex(0),
+      ).toExist();
+      await expect(element(by.id('bookmark-tab-item'))).toHaveLabel(
+        'Bookmarks',
+      );
+    });
+  });
+});
+
+describe('Runtime Config tab — initial state', () => {
+  beforeAll(async () => {
+    await element(by.id('custom-tab-item')).tap();


+import {
+  describeIfiOS,
+  forceTapByLabeliOS,
+  selectSingleFeatureTestsScreen,
+} from '../../e2e-utils';


…iew comments

…g ai review comments" This reverts commit d298452.

…iew comments

…ab detach

Copilot

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

+      await element(by.id('heart').and(by.label('love')))
+        .atIndex(0)
+        .tap();


kligarski · 2026-06-11T13:51:07Z

 async function tapSystemIconOption() {
  await element(by.text('system')).atIndex(1).tap();
 }
+function isIOSVersionAtLeast(version: string): boolean {


Suggested change

function isIOSVersionAtLeast(version: string): boolean {

function isIOSVersionAtLeast(version: string): boolean {

nit

kligarski · 2026-06-11T13:54:02Z

+const tabBarButtonType = isIOSVersionAtLeast('26.0')
+  ? '_UITabButton'
+  : 'UITabBarButton';


This is something that might break in the future if there are some changes to native hierarchy in next iOS versions but I don't think we have really any other option here so it's okay.

LKuchno added 17 commits June 1, 2026 06:59

first draft

c83619e

index with new test screen

d19eafb

chore(test): test-tabs-system-item-ios

aab1c13

scenario update

632e24b

changing e2e flag

0215976

appliyng review suggestion, refactor screen, remove tab without syste…

80f7988

…mitem, add new tab with systemitem and empty title prop - no title

updateing scenario with remarks and to fit new screen look

c775c24

removing NormaTab occurrance from scenario

3e9d21f

changes in text deisplayed on screen for second tab

32f8caf

removing unused ...DEFAULT_TAB_ROUTE_OPTION and reordering function d…

d31829d

…efinition to match route_cofig order

Merge branch 'main' of github.com:software-mansion/react-native-scree…

851860f

…ns into @lkuchno/test-tab-system-item-ios

removing unused import

bfabf5a

corrected screen and scenario

d5b5f5f

style for scrollView and View change

6aa3545

index and scenario files small adjustment after AI review

2029c71

chore(test): new e2e test for test-tabs-system-items-ios scenario

8a45be0

Merge branch 'main' of github.com:software-mansion/react-native-scree…

47a4237

…ns into @lkuchno/e2e-test-tab-system-item-ios

LKuchno requested a review from Copilot June 10, 2026 13:26

Copilot started reviewing on behalf of LKuchno June 10, 2026 13:26 View session

Copilot AI reviewed Jun 10, 2026

View reviewed changes

LKuchno added 4 commits June 10, 2026 15:51

changinf e2eCovarage status in scenario-description + applying ai rev…

d298452

…iew comments

Revert "changinf e2eCovarage status in scenario-description + applyin…

6f093b9

…g ai review comments" This reverts commit d298452.

changing e2eCovarage status in scenario-description + applying ai rev…

c342022

…iew comments

removing unused import

c69e2f1

LKuchno requested a review from kligarski June 10, 2026 14:47

LKuchno added platform:ios Issue related to iOS part of the library area:tabs Issue related to bottom tabs type:chore A general maintenance task, that does not fall into other categories. type:e2e Actions related to e2e maintenance and development, especially automation. labels Jun 10, 2026

mention that e2e test is not supporting ios18

f6584cc

kligarski approved these changes Jun 10, 2026

View reviewed changes

Comment thread FabricExample/e2e/single-feature-tests/tabs/test-tabs-system-item-ios.e2e.ts Outdated

Comment thread FabricExample/e2e/single-feature-tests/tabs/test-tabs-system-item-ios.e2e.ts Outdated

rewrite test to be run on ios18 and ios26, add assertion for search t…

7624fc1

…ab detach

LKuchno requested a review from Copilot June 11, 2026 10:17

Copilot started reviewing on behalf of LKuchno June 11, 2026 10:18 View session

Copilot AI reviewed Jun 11, 2026

View reviewed changes

Comment thread FabricExample/e2e/single-feature-tests/tabs/test-tabs-system-item-ios.e2e.ts Outdated

Comment on lines +393 to +395

await element(by.id('heart').and(by.label('love')))

.atIndex(0)

.tap();

change reference label to switch tabs

484046b

LKuchno requested a review from kligarski June 11, 2026 13:20

kligarski approved these changes Jun 11, 2026

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(test): add e2e test for test-tabs-system-item-ios scenario#4147

chore(test): add e2e test for test-tabs-system-item-ios scenario#4147
LKuchno wants to merge 24 commits into
mainfrom
@lkuchno/e2e-test-tab-system-item-ios

LKuchno commented Jun 10, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

kligarski Jun 11, 2026

Uh oh!

kligarski Jun 11, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	function isIOSVersionAtLeast(version: string): boolean {

	function isIOSVersionAtLeast(version: string): boolean {

Uh oh!

Conversation

LKuchno commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changes

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

kligarski Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

kligarski Jun 11, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

LKuchno commented Jun 10, 2026 •

edited

Loading