chore(test): e2e test for test-tabs-general-appearance-android#4158
Draft
LKuchno wants to merge 15 commits into
Draft
chore(test): e2e test for test-tabs-general-appearance-android#4158LKuchno wants to merge 15 commits into
LKuchno wants to merge 15 commits into
Conversation
…ns into @lkuchno/test-tabs-general-apperance-android
LKuchno
force-pushed
the
@lkuchno/e2e-test-tabs-general-appearance-android
branch
from
c6f1ab5 to
ef1dd06
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new Android-only Tabs scenario (“Tab Bar General Appearance”) and a Detox e2e suite intended to validate tabBarItemLabelVisibilityMode behavior across modes and tab switches.
Changes:
- Added a Detox e2e test suite for Android
tabBarItemLabelVisibilityMode(auto/labeled/selected/unlabeled). - Added a new Android-only single-feature Tabs scenario screen with
tabBarItemTestIDs and aSettingsPickerto toggle label visibility mode. - Added scenario metadata and documentation (scenario description + markdown steps, including e2e coverage note).
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| FabricExample/e2e/single-feature-tests/tabs/test-tabs-general-appearance-android.e2e.ts | New Android-only Detox suite validating label-visibility behavior and persistence across tab switches. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-general-appearance-android/index.tsx | New scenario screen implementing the 4-tab appearance configurations and exposing stable testIDs for Detox. |
| apps/src/tests/single-feature-tests/tabs/test-tabs-general-appearance-android/scenario-description.ts | Registers scenario metadata (Android-only, e2eCoverage incomplete). |
| apps/src/tests/single-feature-tests/tabs/test-tabs-general-appearance-android/scenario.md | Adds manual QA steps and documents e2e coverage limitations. |
| apps/src/tests/single-feature-tests/tabs/index.ts | Registers the new scenario in the Tabs single-feature group. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+72
to
+83
| await expect( | ||
| element(by.id('general-appearance-android-tab-default')), | ||
| ).toBeVisible(); | ||
| await expect( | ||
| element(by.id('general-appearance-android-tab-label')), | ||
| ).toBeVisible(); | ||
| await expect( | ||
| element(by.id('general-appearance-android-tab-ripple')), | ||
| ).toBeVisible(); | ||
| await expect( | ||
| element(by.id('general-appearance-android-tab-indicator')), | ||
| ).toBeVisible(); |
Comment on lines
+86
to
+87
| it('should fallback to default auto mode and persist custom label mode settings across tab switches', async () => { | ||
| await element(by.id('general-appearance-android-tab-default')).tap(); |
Comment on lines
+120
to
+131
| await expect( | ||
| element(by.id('general-appearance-android-tab-default')), | ||
| ).toBeVisible(); | ||
| await expect( | ||
| element(by.id('general-appearance-android-tab-label')), | ||
| ).toBeVisible(); | ||
| await expect( | ||
| element(by.id('general-appearance-android-tab-ripple')), | ||
| ).toBeVisible(); | ||
| await expect( | ||
| element(by.id('general-appearance-android-tab-indicator')), | ||
| ).toBeVisible(); |
LKuchno
added
platform:android
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a Detox e2e test and a corresponding scenario screen for the Android tab bar general appearance scenario, focusing on
tabBarItemLabelVisibilityMode.The e2e test covers all fourtabBarItemLabelVisibilityModevalues (auto,labeled,selected,unlabeled), including label behavior across tab switches. The test is intentionally Android-only and is markede2eCoverage: 'incomplete'since color and visibility attributes on Android views are not assertable via Detox.Closes: https://github.com/software-mansion/react-native-screens-labs/issues/1525
Changes
test-tabs-general-appearance-android.e2e.ts- Detox test suite guarded bydescribeIfAndroid, covering all fourtabBarItemLabelVisibilityModemodes and label mode changes across tab navigationtest-tabs-general-appearance-android/index.tsx- updated with testID and tabBarItemTestID.scenario.mdE2E test section with information about e2e coverage