Skip to content

fix(Android): use per-display density for px→dp conversion in FabricEnabledViewGroup.updateState #4160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ziponia wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −3
Open

fix(Android): use per-display density for px→dp conversion in FabricEnabledViewGroup.updateState #4160

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions android/src/fabric/java/com/swmansion/rnscreens/FabricEnabledViewGroup.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,16 @@ abstract class FabricEnabledViewGroup(
height: Int,
headerHeight: Int,
) {
val realWidth: Float = PixelUtil.toDIPFromPixel(width.toFloat())
val realHeight: Float = PixelUtil.toDIPFromPixel(height.toFloat())
val realHeaderHeight: Float = PixelUtil.toDIPFromPixel(headerHeight.toFloat())
// Use the density of the display this view is attached to, not the process-global one
// captured from the device's main display (PixelUtil). Fabric mounts views using the
// per-display density, so converting back with the global density shrinks/inflates the
// frame pushed to the Shadow Tree whenever the app runs on a display with a different
// density (Samsung DeX, freeform multi-window, external monitors). Both densities are
// identical on single-display devices, so this is a no-op there. See #4159.
val density = context.resources.displayMetrics.density
val realWidth: Float = if (density > 0f) width / density else PixelUtil.toDIPFromPixel(width.toFloat())
val realHeight: Float = if (density > 0f) height / density else PixelUtil.toDIPFromPixel(height.toFloat())
val realHeaderHeight: Float = if (density > 0f) headerHeight / density else PixelUtil.toDIPFromPixel(headerHeight.toFloat())

// Check incoming state values. If they're already the correct value, return early to prevent
// infinite UpdateState/SetState loop.
Expand Down
Loading