Skip to content

MPT-19481 add skip marker with reason for parameter test#293

Merged
jentyk merged 1 commit intomainfrom
feat/MPT-19481
Apr 7, 2026
Merged

MPT-19481 add skip marker with reason for parameter test#293
jentyk merged 1 commit intomainfrom
feat/MPT-19481

Conversation

@jentyk
Copy link
Copy Markdown
Member

@jentyk jentyk commented Apr 7, 2026

Closes MPT-19481

  • Added skip marker with reason to tests/e2e/helpdesk/parameters/test_sync_parameters.py module-level pytestmark, skipping all tests in the file until MPT-19967 is fixed while retaining the flaky designation

@jentyk jentyk requested a review from a team as a code owner April 7, 2026 15:42
@jentyk jentyk requested review from robcsegal and svazquezco April 7, 2026 15:42
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 7, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 16312a6d-b91e-40c9-afbb-8b32f56346cb

📥 Commits

Reviewing files that changed from the base of the PR and between 3f49d0d and 3c5b69c.

📒 Files selected for processing (1)
  • tests/e2e/helpdesk/parameters/test_sync_parameters.py

📝 Walkthrough

Walkthrough

Added a skip marker to the module-level pytestmark in a test file, causing all tests in the module to be skipped pending resolution of issue MPT-19967, while retaining the existing flaky designation.

Changes

Cohort / File(s) Summary
Test Configuration
tests/e2e/helpdesk/parameters/test_sync_parameters.py
Modified module-level pytest markers to add pytest.mark.skip(reason="Unskip after MPT-19967 fixed") alongside existing pytest.mark.flaky, causing all tests in this module to skip until the referenced issue is resolved.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Jira Issue Key In Title ✅ Passed PR title contains Jira issue key MPT-19481 in correct format at the beginning.
Test Coverage Required ✅ Passed The pull request modifies a test file in tests/e2e/helpdesk/parameters/ folder, satisfying the check requirement that test files must be included or modified.
Single Commit Required ✅ Passed The PR contains exactly one commit (3c5b69c) that adds a skip marker with reason to a test file, matching requirements.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 7, 2026

@jentyk jentyk merged commit a66526d into main Apr 7, 2026
4 checks passed
@jentyk jentyk deleted the feat/MPT-19481 branch April 7, 2026 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants