Skip to content

MPT-19489 update skip reasons#295

Merged
jentyk merged 1 commit intomainfrom
feat/MPT-19489
Apr 8, 2026
Merged

MPT-19489 update skip reasons#295
jentyk merged 1 commit intomainfrom
feat/MPT-19489

Conversation

@jentyk
Copy link
Copy Markdown
Member

@jentyk jentyk commented Apr 8, 2026

Closes MPT-19489

  • Update skip reason strings in participant tests to reference MPT-20015
  • Applied changes to test_create_chat_participant, test_update_chat_participant, and test_delete_chat_participant in:
    • tests/e2e/helpdesk/chats/participants/test_async_participants.py
    • tests/e2e/helpdesk/chats/participants/test_sync_participants.py

@jentyk jentyk requested a review from a team as a code owner April 8, 2026 16:07
@jentyk jentyk requested review from albertsola and d3rky April 8, 2026 16:07
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 8, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 7d7bd0a6-11bb-47ac-a3f8-3ada7c560fc0

📥 Commits

Reviewing files that changed from the base of the PR and between 73259e8 and e68db31.

📒 Files selected for processing (2)
  • tests/e2e/helpdesk/chats/participants/test_async_participants.py
  • tests/e2e/helpdesk/chats/participants/test_sync_participants.py

📝 Walkthrough

Walkthrough

Replaced pytest skip reason strings in two test files: changed references from "Unskip after MPT-19124 completed" to "Unskip after MPT-20015 completed" for the create, update, and delete chat participant tests. No other code, assertions, or behavior changed.

Changes

Cohort / File(s) Summary
Test Skip Reason Updates
tests/e2e/helpdesk/chats/participants/test_async_participants.py, tests/e2e/helpdesk/chats/participants/test_sync_participants.py
Updated @pytest.mark.skip(reason=...) strings on three test cases each from "Unskip after MPT-19124 completed" to "Unskip after MPT-20015 completed".

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs


✅ Pre-merge checks override applied

The pre-merge checks have been overridden successfully. You can now proceed with the merge.

Overridden by @jentyk via checkbox on 2026-04-08T16:23:25.921Z.

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Single Commit Required ❓ Inconclusive Unable to verify commit count due to repository state lacking branch tracking information for the feature branch. Run 'git log main..feat/MPT-19489 --oneline | wc -l' locally to confirm if PR contains exactly one commit.
✅ Passed checks (2 passed)
Check name Status Explanation
Jira Issue Key In Title ✅ Passed The PR title contains exactly one Jira issue key in the required format MPT-19489, which matches the expected pattern and aligns with the PR's objective.
Test Coverage Required ✅ Passed PR only modifies test files in tests/ folder (test_async_participants.py and test_sync_participants.py). No code files outside tests/ directory are modified.

Comment @coderabbitai help to get the list of available commands and usage tips.

@jentyk jentyk changed the title MPT-19489 update skip reasons referencing MPT-20015 in participant tests MPT-19489 update skip reasons Apr 8, 2026
@jentyk
Copy link
Copy Markdown
Member Author

jentyk commented Apr 8, 2026

@CodeRabbit review

@jentyk
Copy link
Copy Markdown
Member Author

jentyk commented Apr 8, 2026

@CodeRabbit approve

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 8, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 8, 2026

✅ Actions performed

Comments resolved and changes approved.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 8, 2026

@jentyk jentyk merged commit a6b5f31 into main Apr 8, 2026
4 checks passed
@jentyk jentyk deleted the feat/MPT-19489 branch April 8, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants