Skip to content

MPT-13785 remove obsolete skip markers from category tests#306

Merged
jentyk merged 1 commit intomainfrom
fix/MPT-13785
Apr 17, 2026
Merged

MPT-13785 remove obsolete skip markers from category tests#306
jentyk merged 1 commit intomainfrom
fix/MPT-13785

Conversation

@jentyk
Copy link
Copy Markdown
Member

@jentyk jentyk commented Apr 17, 2026

Closes MPT-13785

  • Re-enabled previously skipped category tests by removing obsolete @pytest.mark.skip decorators.
  • Async tests re-enabled: test_publish_category, test_unpublish_category (tests/e2e/notifications/categories/test_async_categories.py).
  • Sync tests re-enabled: test_update_category, test_publish_category, test_unpublish_category (tests/e2e/notifications/categories/test_sync_categories.py).
  • No changes to test bodies, assertions, fixtures, or public API signatures; only skip markers were removed.

@jentyk jentyk requested a review from a team as a code owner April 17, 2026 08:21
@jentyk jentyk requested review from albertsola and robcsegal April 17, 2026 08:21
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 17, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: 07c2d284-0328-4414-9d05-caa239316290

📥 Commits

Reviewing files that changed from the base of the PR and between 5d695f2 and 9d34f95.

📒 Files selected for processing (2)
  • tests/e2e/notifications/categories/test_async_categories.py
  • tests/e2e/notifications/categories/test_sync_categories.py
💤 Files with no reviewable changes (2)
  • tests/e2e/notifications/categories/test_sync_categories.py
  • tests/e2e/notifications/categories/test_async_categories.py

📝 Walkthrough

Walkthrough

Removed @pytest.mark.skip(...) decorators from five category e2e tests across async and sync test files so those tests will run; no test logic, assertions, or public API signatures were changed.

Changes

Cohort / File(s) Summary
Category e2e tests — async
tests/e2e/notifications/categories/test_async_categories.py
Removed @pytest.mark.skip(...) from test_publish_category and test_unpublish_category, enabling their execution.
Category e2e tests — sync
tests/e2e/notifications/categories/test_sync_categories.py
Removed @pytest.mark.skip(...) from test_update_category, test_publish_category, and test_unpublish_category, enabling their execution.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Jira Issue Key In Title ✅ Passed PR title contains exactly one properly formatted Jira issue key (MPT-13785) at the beginning.
Test Coverage Required ✅ Passed PR only modifies test files in tests/e2e/notifications/categories/ directory with no changes to code files outside tests folder.
Single Commit Required ✅ Passed The PR contains exactly one commit (9d34f95 test(e2e): remove obsolete skip markers from category tests), meeting the single-commit requirement.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@tests/e2e/notifications/categories/test_sync_categories.py`:
- Line 34: Run Ruff formatting on the failing test file to satisfy `ruff format
--check`: reformat test_sync_categories.py with Ruff (not Black), fix the
formatting issues identified around the test definitions (the failures reported
at the file and at the other occurrences), then stage and commit the formatted
file and re-run `ruff format --check` (or `ruff check`) to ensure CI passes
before pushing.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro

Run ID: dc5e6a6d-7de4-4623-a9b8-234e559bbba0

📥 Commits

Reviewing files that changed from the base of the PR and between c1d8456 and b996d80.

📒 Files selected for processing (2)
  • tests/e2e/notifications/categories/test_async_categories.py
  • tests/e2e/notifications/categories/test_sync_categories.py

Comment thread tests/e2e/notifications/categories/test_sync_categories.py Outdated
@jentyk
Copy link
Copy Markdown
Member Author

jentyk commented Apr 17, 2026

@CodeRabbit review

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 17, 2026

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@sonarqubecloud
Copy link
Copy Markdown

@jentyk jentyk merged commit 7c4e679 into main Apr 17, 2026
4 checks passed
@jentyk jentyk deleted the fix/MPT-13785 branch April 17, 2026 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants