fix(render): 修复发送的文本中的错误换行 - #237
Merged
Merged
Conversation
移除文本缓冲区连接时换行操作，同时修正了平台名称显示样式中的大小写转换问题
Contributor
审阅者指南（在小型 PR 上折叠）审阅者指南此 PR 调整了文本渲染行为：在刷新缓冲文本时移除非预期的换行插入，并更新平台名称标签样式，使其保留原始大小写，而不再强制转换为全大写。 在 build_nodes 中更新后的缓冲文本刷新序列图sequenceDiagram
participant Parser as build_nodes
participant Buffer as text_buffer
participant Flush as flush_text
participant Output as nodes
Parser->>Buffer: accumulate text fragments
Parser->>Flush: flush_text()
activate Flush
Flush->>Buffer: check if non_empty
alt buffer_non_empty
Flush->>Flush: text = "".join(text_buffer)
Flush->>Output: append f"{author_name}：{text}"
Flush->>Buffer: text_buffer = []
else buffer_empty
Flush->>Flush: [do_nothing]
end
deactivate Flush
文件级变更
提示与命令与 Sourcery 交互
自定义你的体验访问你的 控制面板 以：
获取帮助Original review guide in EnglishReviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR adjusts text rendering behavior by removing unintended newline insertion when flushing buffered text, and updates the platform name label style to preserve its original casing instead of forcing uppercase. Sequence diagram for updated buffered text flushing in build_nodessequenceDiagram
participant Parser as build_nodes
participant Buffer as text_buffer
participant Flush as flush_text
participant Output as nodes
Parser->>Buffer: accumulate text fragments
Parser->>Flush: flush_text()
activate Flush
Flush->>Buffer: check if non_empty
alt buffer_non_empty
Flush->>Flush: text = "".join(text_buffer)
Flush->>Output: append f"{author_name}：{text}"
Flush->>Buffer: text_buffer = []
else buffer_empty
Flush->>Flush: [do_nothing]
end
deactivate Flush
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
嗨，我在这里留下了一些整体性的反馈：
- 在
flush_text中，移除换行连接和strip()会改变空白字符和换行符的处理方式；请考虑text_buffer中的首尾空格，或者缓冲片段之间缺少分隔符，是否会在最终渲染输出中导致意料之外的格式问题。 - 从平台名称的 span 中移除
uppercase会改变与其他平台标签的视觉一致性；如果只有某些平台需要保持大写样式，建议通过数据或条件类来控制，而不是在全局范围内统一添加或移除该类。
给 AI 代理的提示
请根据本次代码评审中的评论进行改进：
## 总体评论
- 在 `flush_text` 中，移除换行连接和 `strip()` 会改变空白字符和换行符的处理方式；请考虑 `text_buffer` 中的首尾空格，或者缓冲片段之间缺少分隔符，是否会在最终渲染输出中导致意料之外的格式问题。
- 从平台名称的 span 中移除 `uppercase` 会改变与其他平台标签的视觉一致性；如果只有某些平台需要保持大写样式，建议通过数据或条件类来控制，而不是在全局范围内统一添加或移除该类。帮我变得更有用！请在每条评论上点击 👍 或 👎，我会根据你的反馈改进后续评审。
Original comment in English
Hey - I've left some high level feedback:
- In
flush_text, removing the newline join andstrip()changes how whitespace and line breaks are handled; consider whether leading/trailing spaces intext_bufferor missing separators between buffered segments could result in unintended formatting in the rendered output. - The removal of
uppercasefrom the platform name span will change visual consistency with other platform labels; if only certain platforms should retain uppercase styling, consider handling this via data or conditional classes rather than applying/removing the class globally.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- In `flush_text`, removing the newline join and `strip()` changes how whitespace and line breaks are handled; consider whether leading/trailing spaces in `text_buffer` or missing separators between buffered segments could result in unintended formatting in the rendered output.
- The removal of `uppercase` from the platform name span will change visual consistency with other platform labels; if only certain platforms should retain uppercase styling, consider handling this via data or conditional classes rather than applying/removing the class globally.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
移除文本缓冲区连接时换行操作，同时修正了平台名称显示样式中的大小写转换问题
Summary by Sourcery
调整消息输出中的文本渲染和平台名称显示。
错误修复：
Original summary in English
Summary by Sourcery
Adjust text rendering and platform name display in message output.
Bug Fixes: