chore: release @solana/pay-kit 0.5.0 and deprecate @solana/mpp#215
Open
EfeDurmaz16 wants to merge 3 commits into
Open
chore: release @solana/pay-kit 0.5.0 and deprecate @solana/mpp#215EfeDurmaz16 wants to merge 3 commits into
EfeDurmaz16 wants to merge 3 commits into
Conversation
Bumps @solana/pay-kit to 0.5.0 for publish. Picks up the concurrent-signature-replay (TOCTOU) charge-verify fix (solana-foundation#211) that flows in through the @solana/mpp dist exports.
Adds a deprecation README pointing users to @solana/pay-kit and ships it on the package (the mpp publish job no longer overwrites it with the root pay-kit README). Marks the mpp publish job and the workflow input as deprecated: it is retained only to cut the final @solana/mpp release, which carries the solana-foundation#211 TOCTOU fix. The actual 'npm deprecate @solana/mpp' is run out of band after that release.
Keeps the deprecation notice consistent across all surfaces (npm, tarball README, and the GitHub release). The final @solana/mpp release now points users to @solana/pay-kit in its release notes instead of showing a plain install line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bumps
@solana/pay-kitto0.5.0for release and deprecates@solana/mppinfavor of it. No wire or runtime behavior changes: this is a version string, a
deprecation README, and a publish-workflow tweak.
Read order
typescript/packages/pay-kit/package.json— the bump,0.4.0to0.5.0. One line.typescript/packages/mpp/README.md— new deprecation notice. Check themigration path (
@solana/mppto@solana/pay-kit) and the note that thefinal release carries the fix(mpp): close concurrent-signature-replay TOCTOU in TS charge verify #211 TOCTOU fix.
.github/workflows/npm-publish.yml— the mpp pack step no longer copies theroot pay-kit README over the package one, so the deprecation notice ships;
the mpp job and the workflow input are marked deprecated. Confirm the pack
step still yields a valid tarball with
dist/.Generated vs handwritten
package.jsonversion bump, 1 line.mpp/README.md(24 lines of docs) andnpm-publish.yml(about 6 net logic lines plus comments). Roughly 30handwritten lines, all docs and CI config. No product code changes.
Test plan
No product build needed (version + docs + CI). To confirm the mpp tarball ships
the deprecation README instead of the root one:
Workflow stays valid YAML:
python3 -c "import yaml; yaml.safe_load(open('.github/workflows/npm-publish.yml'))".Reviewer note
One deliberate judgment call, and the place to be skeptical: I did not remove
the
@solana/mpppublish job. The #211 security fix lives in@solana/mpp(
server/Charge.ts,server/keyLock.ts) and published mpp latest (0.6.0)does not have it, so the job is kept, marked deprecated, to cut one final
@solana/mpp@0.7.0that carries the fix beforenpm deprecate. If you wouldrather strip the job in this PR, the final mpp release has to be cut from
pre-merge main first. Publish sequence is spelled out in the PR description.
Also: the deprecation README ships even though it is not in the package
filesarray, because npm always includes
README.md.Fable 5 self-review
Verdict: Approve. Small, self-contained, no code paths touched; the version bump
picks up #211 through pay-kit's mpp dist dependency, which is the intended flow.
If this were someone else's PR I would flag two things: (1) keeping the mpp
publish job is a conscious deviation from "remove mpp from publish" and depends
on the maintainer running the final mpp release then
npm deprecatein order, sothe sequencing is the real risk, not the code; (2) I did not run a local
pnpm buildsince nothing compiles differently here, so the tarball-READMEassertion in the test plan is reasoned, not executed. CI covers the build.
Fable 5 self-review