fix(surfnet): terminates the cli program on sigterm#589
Open
0xzrf wants to merge 1 commit intosolana-foundation:mainfrom
Open
fix(surfnet): terminates the cli program on sigterm#5890xzrf wants to merge 1 commit intosolana-foundation:mainfrom
0xzrf wants to merge 1 commit intosolana-foundation:mainfrom
Conversation
Collaborator
|
@0xzrf were you able to successfully test this? I built and ran this branch, but SIGTERM didn't seem to do anything |
Contributor
Author
|
@MicaiahReid umm, It does seem to run in my end. kill -15 <PID> |
5419677 to
2129ad9
Compare
Collaborator
Hmm, I'm on macos and that's not working for me 🤔 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summery
Stops the surfpool surnet execution immediately after calling the
SIGTERMChanges
Added
terminationfeature to thectrlccrate, which signals thectrlc:: set_handlerto call theSimnetCommand::Terminate(None);onSIGTERMsignalCloses #514