Merged
Conversation
febo
force-pushed
the
febo/refactor-ci
branch
2 times, most recently
from
c216d13 to
87c2596
Compare
lorisleiva
reviewed
Apr 2, 2025
lorisleiva
reviewed
Apr 2, 2025
Member
lorisleiva
left a comment
lorisleiva
left a comment
There was a problem hiding this comment.
Thanks! Just a few comments and we're good to go.
Co-authored-by: Loris Leiva <loris.leiva@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Currently, CI is not inline with other repositories – e.g., it does not include
auditandspellchecker.Solution
Update the scripts and CI. It also fixes spelling errors and updates the dependencies to use the individual SDK crates.