Skip to content

program: Add batch instruction #884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joncinque merged 10 commits into from
Mar 25, 2026
Merged

program: Add batch instruction #884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
030c146
Add Batch instruction variants
abelmarnk Dec 7, 2025
eb57a4c
Add Batch de/ser helpers
abelmarnk Dec 7, 2025
a0d6078
Add Batch instruction processor
abelmarnk Dec 7, 2025
2ef74ed
Add Batch instruction tests
abelmarnk Feb 3, 2026
4995d14
Review fixes - tests
abelmarnk Mar 23, 2026
d365a82
Review fixes - checks
abelmarnk Mar 23, 2026
28b2a8a
clippy fix
abelmarnk Mar 23, 2026
9bd82e4
nit
abelmarnk Mar 23, 2026
f0aa0d2
Review fixes II - checks
abelmarnk Mar 24, 2026
3e6f68c
nit - II
abelmarnk Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,803 changes: 1,803 additions & 0 deletions clients/rust-legacy/tests/batch.rs
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions clients/rust-legacy/tests/close_account.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ async fn fail_init_after_close_account() {
assert_eq!(
error,
TokenClientError::Client(Box::new(TransportError::TransactionError(
TransactionError::InstructionError(2, InstructionError::InvalidAccountData,)
TransactionError::InstructionError(2, InstructionError::IncorrectProgramId,)
)))
);
let error = token.get_account(destination).await.unwrap_err();
Expand Down Expand Up @@ -160,7 +160,7 @@ async fn fail_init_after_close_mint() {
assert_eq!(
error,
TokenClientError::Client(Box::new(TransportError::TransactionError(
TransactionError::InstructionError(2, InstructionError::InvalidAccountData,)
TransactionError::InstructionError(2, InstructionError::IncorrectProgramId)
)))
);
let error = token.get_account(destination).await.unwrap_err();
Expand Down
2 changes: 1 addition & 1 deletion clients/rust-legacy/tests/transfer_fee.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -496,7 +496,7 @@ async fn fail_unsupported_mint() {
assert_eq!(
error,
TokenClientError::Client(Box::new(TransportError::TransactionError(
TransactionError::InstructionError(0, InstructionError::InvalidAccountData)
TransactionError::InstructionError(0, InstructionError::IncorrectProgramId)
Copy link
Copy Markdown
Contributor

@febo febo Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an example of the change that I mentioned about the ownership checks. Probably it is ok to return a different error. Alternatively, we could move the owner checks to be the last statement of the processor. We would still get a different error if the account is not owned by the program, but other validation checks will stay the same.

Copy link
Copy Markdown
Contributor

@joncinque joncinque Mar 25, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you mean, but keeping the source code easier to read is more important in my opinion

)))
);
}
Expand Down
Loading
Loading