Style analysis for examples#1172
Merged
mkalkbrenner merged 4 commits intosolariumphp:masterfrom Mar 13, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1172 +/- ##
=======================================
Coverage 98.21% 98.21%
=======================================
Files 404 404
Lines 10647 10647
=======================================
Hits 10457 10457
Misses 190 190
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a52e34f to
0c6f49c
Compare
0c6f49c to
cf81cac
Compare
cf81cac to
3216e70
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added the
examplesdir to.styleci.yml, fixed the errors StyleCI reported, and then applied the same fixes to the code examples indocs. (I don't think StyleCI can analyse the codeblocks inside Markdown.)The most visible part will be that we no longer use
array(...)but[...]as we already did in the codebase. Feels more modern IMHO. Besides that the bulk of the changes is removing whitespace around the concatenation operator..Also added a few manual improvements, e.g. using
$client->select()instead of$client->execute()because it plays nicer with an IDE's autocomplete.