Remove deprecated curl_close() for PHP 8.5 compatibility (6.4.x backport)#1178
Open
mably wants to merge 1 commit intosolariumphp:6.4.xfrom
Open
Remove deprecated curl_close() for PHP 8.5 compatibility (6.4.x backport)#1178mably wants to merge 1 commit intosolariumphp:6.4.xfrom
mably wants to merge 1 commit intosolariumphp:6.4.xfrom
Conversation
Member
|
@mably You'll have to make this PR against the |
curl_close() has been a no-op since PHP 8.0 and is deprecated since PHP 8.5. CurlHandle objects are freed automatically when they fall out of scope. Fixes solariumphp#1177
mably
force-pushed
the
fix/remove-deprecated-curl-close
branch
from
aa57e32 to
8f11b58
Compare
mably
changed the title
Author
|
Sorry. It should be ok now. |
mably
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
curl_close()has been a no-op since PHP 8.0 (CurlHandle objects are freed automatically) and is deprecated since PHP 8.5, triggering:This was already fixed on
masterin #1170 but not backported to6.x.Fixes #1177