Experimental nested expanded fields idea#35
Draft
yurii-prykhodko-solid wants to merge 5 commits intomainfrom
Draft
Experimental nested expanded fields idea#35yurii-prykhodko-solid wants to merge 5 commits intomainfrom
yurii-prykhodko-solid wants to merge 5 commits intomainfrom
Conversation
Comment on lines
6
to
+10
| class SubscriptionExpanded { | ||
| final Subscription subscription; | ||
| final List<Discount>? discounts; | ||
| final List<DiscountExpanded>? discounts; | ||
| final InvoiceExpanded? latestInvoice; | ||
| final Customer? customer; | ||
| final CustomerExpanded? customer; |
Collaborator
Author
There was a problem hiding this comment.
This is probably the pattern we need to stick with. In most cases the included fields will have nesting of their own, and in order to minimize breaking changes as we add more "expanded" fields -- we'll need to make all nested fields xExpanded:
class ObjExpanded {
final Obj obj;
final NestedAExpanded nestedA;
final NestedB...
}
Comment on lines
+39
to
+40
| for (int i = 0; i < expand.innerNestedFields.length; i++) | ||
| 'expand[$i]': expand.innerNestedFields.elementAt(i), |
Collaborator
Author
There was a problem hiding this comment.
This will need to be extracted into a reusable piece. Maybe a utility on ExpandableField.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.