Refactor create-solid and remove other packages#58
Merged
Tommypop2 merged 35 commits intosolidjs-community:mainfrom Jan 19, 2025
Merged
Refactor create-solid and remove other packages#58Tommypop2 merged 35 commits intosolidjs-community:mainfrom
create-solid and remove other packages#58Tommypop2 merged 35 commits intosolidjs-community:mainfrom
Conversation
refactor create-solid code
remove unused `ui` package
This allows for `create-solid` to be imported by another package and used there
…nder a subcommand
feat: export nothing from `create-solid` so it can be as small as possible
This should help catch platform-specific bugs
dev-rb
reviewed
Jan 19, 2025
refactor: make `jiti` a workspace dependency
feat: use `turbo watch` for automatically rebuilding on change
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Completely refactor the
create-solidpackage to improve the maintainability of the CLIUsing a separate package for each subcommand significantly reduces the risk of features being added in other subcommands (add, for example) impacting the critical
createlogic.Removed the more-complete
@solid-cli/coreCLI package, as well as logic for all subcommands apart fromcreate. These would take a lot more effort to refactor and aren't really necessary for now.Added tests to
create-solid