Skip to content

fix: explicit type imports#2001

Merged
atilafassina merged 1 commit into
mainfrom
explicity-type-imports
Nov 19, 2025
Merged

fix: explicit type imports#2001
atilafassina merged 1 commit into
mainfrom
explicity-type-imports

Conversation

@brenelz

@brenelz brenelz commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

PR Checklist

Copied the bare example outside the monorepo and was having some type issues that explicty import type fixed

@changeset-bot

changeset-bot Bot commented Nov 14, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 784de8c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify

netlify Bot commented Nov 14, 2025

Copy link
Copy Markdown

Deploy Preview for solid-start-landing-page failed. Why did it fail? →

Name Link
🔨 Latest commit 784de8c
🔍 Latest deploy log https://app.netlify.com/projects/solid-start-landing-page/deploys/691671c980d4b10008cfe7de

@pkg-pr-new

pkg-pr-new Bot commented Nov 14, 2025

Copy link
Copy Markdown

Open in StackBlitz

npm i https://pkg.pr.new/@solidjs/start@2001

commit: 784de8c

@atk

atk commented Nov 14, 2025

Copy link
Copy Markdown
Contributor

It looks like you also changed unrelated formatting. Please either remove those changes or document them (e.g. fix formatting).

@atilafassina

Copy link
Copy Markdown
Member

It looks like you also changed unrelated formatting. Please either remove those changes or document them (e.g. fix formatting).

the whole codebase needs proper formatting rules and being reformatted accordingly.

we are setting the formatting in a separate PR

@atilafassina atilafassina merged commit dbff19d into main Nov 19, 2025
4 of 5 checks passed
@atilafassina atilafassina deleted the explicity-type-imports branch November 19, 2025 18:19
@huseeiin

Copy link
Copy Markdown
Contributor

It looks like you also changed unrelated formatting. Please either remove those changes or document them (e.g. fix formatting).

the whole codebase needs proper formatting rules and being reformatted accordingly.

we are setting the formatting in a separate PR

i'm trying to make a PR but when i format the entire style changes even tho there's a .prettierrc

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants