fix: reject server function calls on 5xx responses without X-Error#2159
Open
adipascu wants to merge 2 commits into
Open
fix: reject server function calls on 5xx responses without X-Error#2159adipascu wants to merge 2 commits into
adipascu wants to merge 2 commits into
Conversation
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: d384715 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What is the current behavior?
Server function calls only reject when the response carries an
X-Errorheader. A 5xx produced below the handler (server function module crashing at import time, proxy/CDN error, dead worker) has noX-Error, so the promise resolves and callers mistake server failure for success.Minimal reproduction: https://github.com/adipascu/solid-start-server-fn-500-repro
What is the new behavior?
Responses with status >= 500 throw the deserialized result, like
X-Errordoes, falling back to anErrorwith the status code when the body yields nothing. 4xx responses are untouched since server functions can legitimately return them withoutX-Error.Other information
I see the Tests workflow is failing on
1.xitself (every 2026 run is red, including the 1.3.2 release commits), so the failures here are pre-existing. Should I retarget this PR tomain? Itspackages/start/src/fns/client.tshas the same logic, and I'm happy to do both.