Skip to content

Removes correlation explorer header gap - #161

Merged
soliktomasz merged 4 commits into
mainfrom
codex/issue-155-replay-correlation-explorer
Jul 28, 2026
Merged

Removes correlation explorer header gap#161
soliktomasz merged 4 commits into
mainfrom
codex/issue-155-replay-correlation-explorer

Conversation

@soliktomasz

@soliktomasz soliktomasz commented Jul 28, 2026

Copy link
Copy Markdown
Owner

The correlation explorer's header previously included an unnecessary 16-pixel bottom margin, which rendered as a dark, full-width strip due to the panel's background. Additionally, the search input field explicitly set a transparent background, making its appearance inconsistent with standard application inputs.

This change removes the bottom margin from the correlation explorer header, allowing its existing border to serve as the sole divider and ensuring a continuous header surface. It also removes the transparent background override from the search text box, restoring the standard input background for improved visual consistency.

New XAML contract tests verify the absence of the header margin and the standard search input background.

Relates to issue-155

Summary by CodeRabbit

  • Bug Fixes

    • Removed the unwanted dark gap beneath the Correlation Explorer header.
    • Improved visual continuity between the header and command bar.
    • Restored the search field’s standard background styling for a more consistent appearance.
  • Tests

    • Added coverage to verify the Correlation Explorer header and search field styling.

@soliktomasz
soliktomasz merged commit 1d17890 into main Jul 28, 2026
3 of 4 checks passed
@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7193ba2e-594f-487b-af76-e3a2efaac504

📥 Commits

Reviewing files that changed from the base of the PR and between 27651fc and 43e7499.

📒 Files selected for processing (5)
  • BusLane.Tests/Views/CorrelationExplorerViewTests.cs
  • BusLane/Views/Controls/CorrelationExplorerView.axaml
  • BusLane/Views/MainWindow.axaml
  • docs/plans/2026-07-28-correlation-explorer-header-gap-design.md
  • docs/plans/2026-07-28-correlation-explorer-header-gap.md

📝 Walkthrough

Walkthrough

The Correlation Explorer header no longer has a bottom margin, and its search box now uses the standard background styling. A new XAML contract test verifies both attributes, with two design-plan documents describing the change and verification steps.

Changes

Correlation Explorer surface

Layer / File(s) Summary
Header and search surface contract
BusLane/Views/MainWindow.axaml, BusLane/Views/Controls/CorrelationExplorerView.axaml, BusLane.Tests/Views/CorrelationExplorerViewTests.cs, docs/plans/*correlation-explorer-header-gap*
The header margin and search background override were removed, and regex-based grouped assertions verify the resulting XAML structure and local styling attributes. Design plans document the targeted changes and test/build verification steps.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested labels: enhancement

Poem

I’m a rabbit hopping through the view,
The header gap is gone from view.
Search now wears its proper hue,
Tests check every XAML cue.
Sniff, sniff—clean styles anew!

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/issue-155-replay-correlation-explorer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@soliktomasz
soliktomasz deleted the codex/issue-155-replay-correlation-explorer branch July 28, 2026 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant