Don't coerce nil for collection attributes when required is false#354
Open
mherold wants to merge 1 commit intosolnic:masterfrom
Open
Don't coerce nil for collection attributes when required is false#354mherold wants to merge 1 commit intosolnic:masterfrom
mherold wants to merge 1 commit intosolnic:masterfrom
Conversation
forest
added a commit
to irphilli/tracker_api
that referenced
this pull request
Mar 18, 2016
Update this code when this is merged in Virtus. * Don't coerce nil for collection attributes when required is false * solnic/virtus#354
|
👍 |
Repository owner
locked and limited conversation to collaborators
Apr 5, 2016
Without this fix, collection attributes can never be set to nil when coercion is enabled (because the coercer coerces nil to an empty array).
mherold
force-pushed
the
fix-collection-nil-coercion
branch
from
f391d1f to
5701901
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Without this fix, collection attributes can never be set to nil when
coercion is enabled (because the coercer coerces nil to an empty array).
This should fix #334.
I originally suggested a change in a more central location, see this comment, but looking at the specs it seemed more appropriate to make this change only for collection attributes.