Allow fallback to default value when assigning nil#370
Open
lime wants to merge 3 commits intosolnic:masterfrom
Open
Allow fallback to default value when assigning nil#370lime wants to merge 3 commits intosolnic:masterfrom
lime wants to merge 3 commits intosolnic:masterfrom
Conversation
:use_default_on_nil makes an attribute fallback to the :default value (if one is set) when attempting to set it to nil
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a revamp of the feature proposed in #292, though named differently. I tried to avoid confusion by making the name pretty explicit, but I'm open to suggestions if you feel there are better naming options.
When configuring
use_default_on_nil: true, an attribute which gets set tonilwill fallback to the:defaultvalue.The implementation is heavily based on the
:nullify_blankoption in #314.Let me know what you think. :)