Fix but in coerce when Rails 5 params are passed in#388
Open
natesholland wants to merge 1 commit intosolnic:masterfrom
Open
Fix but in coerce when Rails 5 params are passed in#388natesholland wants to merge 1 commit intosolnic:masterfrom
natesholland wants to merge 1 commit intosolnic:masterfrom
Conversation
Since parameters in Rails 5 no longer sub class from Hash and blow up when you try to call to_hash on them when they are not permitted the coerce method in Virtus was no longer working. Since the hash here is not mass assigned but instead only permits known attributes it is safe to call `.to_unsafe_hash` if it is defined on the attributes. If not we fall back to the previous behavior. This also adds specs to capture the bahavior I was seeing on Rails 5.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since parameters in Rails 5 no longer sub class from Hash and blow up
when you try to call to_hash on them when they are not permitted the
coerce method in Virtus was no longer working. Since the hash here is
not mass assigned but instead only permits known attributes it is safe
to call
.to_unsafe_hashif it is defined on the attributes. If not wefall back to the previous behavior.
This also adds specs to capture the bahavior I was seeing on Rails 5.