test(backend): add unit tests for authCookie and networkSafety#235
Merged
solomon2773 merged 1 commit intoJun 28, 2026
Merged
Conversation
solomon2773
approved these changes
Jun 28, 2026
solomon2773
left a comment
solomon2773
left a comment
Owner
There was a problem hiding this comment.
Focused backend checks passed locally: authCookie/networkSafety Jest coverage and backend typecheck. The IPv6 literal hostname fix is a security-positive correction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds comprehensive unit test suites for two core backend helper modules:
backend-api/authCookie.ts: Tests cookie parsing, reading, setting, and clearing.backend-api/networkSafety.ts: Tests URL and protocol validation, lexical IP matches, and async DNS resolution.Additionally, this resolves a minor bug in the synchronous check within
assertSafeUrlto properly strip square brackets from IPv6 hostnames (e.g.[::1]), ensuring literal local IPv6 addresses are blocked synchronously in the fast pass.Closes #220
Closes #221