Conversation
jalextowle
left a comment
jalextowle
left a comment
There was a problem hiding this comment.
I like the addition of the test! Can't wait to see this one get merged.
| @@ -0,0 +1,9 @@ | |||
| git status /git diff - shows any changes made to local files relative to repo | |||
There was a problem hiding this comment.
This file needs to be removed before this PR can be merged.
| pragma solidity ^0.4.25; | ||
|
|
||
| interface IACLOracle { | ||
| function canPerform(address who, address where, bytes32 what, uint256[] how) external view returns (bool); |
There was a problem hiding this comment.
Let's space out the parameters like so:
interface IACLOracle {
function canPerform(
address who,
address where,
bytes32 what,
uint256[] how
)
external
view returns (bool);
}
This way, our Solidity code will follow the 0x style guide. (which will hopefully be defined by our style rules one day!).
|
|
||
| impl ParseNode { | ||
| // Add a token to this node's children | ||
| fn add_child(&mut self, token: lex_4_25::Token) { |
There was a problem hiding this comment.
To recap on our conversation the other day, I don't think these changes should be included because it muddles the "path of blame" for these lines. Since you didn't actually touch the code, you shouldn't be on the "path of blame".
This comment applies to all such changes. I may reevaluate this in the future, but I think this restriction makes sense for now.
| } | ||
| */ | ||
| } | ||
| } |
There was a problem hiding this comment.
You need to add the test before this closing brace. This will make your tests not compile.
3 participants
No description provided.