feat(desktop): integrated terminal — server + container shells - #17
Open
lam0819 wants to merge 4 commits into
Open
feat(desktop): integrated terminal — server + container shells#17lam0819 wants to merge 4 commits into
lam0819 wants to merge 4 commits into
Conversation
Adds a Terminal panel to the management window: tabbed server SSH shells and per-app container shells (docker exec), full-screen toggle, live resize. - internal/ssh: Executor.InteractiveShell — PTY-backed session bridging stdio, with an out-of-band resize control frame (WindowChange). - cmd/neo-bridge: `pty` subcommand — raw interactive mode reusing neo's SSH auth (login shell or `docker exec -it <container> sh`). - src-tauri/pty.rs: spawns `neo-bridge pty` via std::process (posix_spawn — no fork abort on macOS) and streams raw bytes (no line buffering), so per-key echo and prompts render correctly. Commands: pty_spawn/write/resize/kill. - frontend: xterm.js TerminalPanel + tabs store + TerminalSection wired into Management. Bridge resolves auth, so tabs need only a server name (+ app).
The release build passed APPLE_CERTIFICATE unconditionally; with no cert
secret Tauri still ran `security import` and aborted ("failed to import
keychain certificate"), failing darwin-aarch64. Split into a signed step
(only when the cert secret exists) and an unsigned step (macOS ad-hoc;
Windows still signs via the composed thumbprint).
Contributor
Author
|
Also includes a release-pipeline fix: macOS signing is now gated on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the integrated terminal onto the mature desktop app (branch
plan/neo-desktop-tray-app).What
A Terminal panel in the management window:
docker exec -it … sh)How (self-contained, low-risk)
internal/ssh:Executor.InteractiveShell— PTY session bridging stdio + an out-of-band resize control frame (\x1eR<cols>x<rows>\n→WindowChange).cmd/neo-bridge: newptysubcommand — raw interactive mode reusing neo's own SSH auth (no key hunting). Bypasses the JSON protocol server.src-tauri/pty.rs: spawnsneo-bridge ptyviastd::process(posix_spawn— avoids the macOS "crashed on child side of fork pre-exec" abort) and streams raw bytes (the shell plugin line-buffers, which breaks per-keystroke echo and$/password:prompts).TerminalPanel+terminalsstore +TerminalSection, added as one.panelinManagement.tsx. No changes totauri-api, the apps table, or servers UI.Validation
npm run build(tsc strict) ✓tauri build --target aarch64-apple-darwin✓ (Rust + bundle)flint-153, per-key echo + resize correct.Does not touch the bridge JSON protocol, updater, or existing tests.