Skip to content

Somiaj new grades page#15

Closed
Alex-Jordan wants to merge 3 commits into
somiaj:new-grades-pagefrom
Alex-Jordan:somiaj-new-grades-page
Closed

Somiaj new grades page#15
Alex-Jordan wants to merge 3 commits into
somiaj:new-grades-pagefrom
Alex-Jordan:somiaj-new-grades-page

Conversation

@Alex-Jordan
Copy link
Copy Markdown

What do you think about these?

  1. For a test, move the overall score report and the report of which version is the relevant version all to one line. For example, the second assignment here:
Screenshot 2026-05-20 at 5 27 34 PM
  1. Add a row to the tables to show the weights of each problem. But before objecting to the excess space this takes up...
  2. Add toggles to reveal weights and attempt counts:
Screenshot 2026-05-20 at 5 29 11 PM

Those rows are hidden by default as in the first screenshot. No javascript is used for this, just css.

@Alex-Jordan
Copy link
Copy Markdown
Author

Remind me what I run to format an scss file to make it look pretty?

@Alex-Jordan Alex-Jordan force-pushed the somiaj-new-grades-page branch from e1f7f06 to 8b5e332 Compare May 21, 2026 00:45
@Alex-Jordan
Copy link
Copy Markdown
Author

The fake buttons here are not accessible, so I need to work on that.

Right now, they are actually labels for hidden checkboxes. The checked status of the checkboxes is what controls whether the table rows are hidden or not. I could reveal the checkboxes themselves, which would make it all accessible. But I want to explore if I can make it accessible without having to see those. Stepping away for now though.

@somiaj
Copy link
Copy Markdown
Owner

somiaj commented May 21, 2026

Maybe use local storage to store if the weights/attempts are shown/hidden.

@somiaj
Copy link
Copy Markdown
Owner

somiaj commented May 21, 2026

You could also add a data atribute vs a checkbox, but I'd use local storage that way it remebers a user's preference.

Comment on lines 28 to 29
<br>
% }
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this <br>.

</div>
% }
%
% if (@$open || @$reduced || @$closed) {
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It could be possible only things begins shown are open/reduced/closed tests with either no versions taken or hidden grades, and then there wouldn't be anything to toggle. Probably rare and not worth trying to be that exact, just pointing that could happen.

@somiaj
Copy link
Copy Markdown
Owner

somiaj commented May 21, 2026

@Alex-Jordan I took your suggestion and implemented them with javascript and using local storage to recall the user's preference. Would you like me to send the patch here (it is top of my branch, not your changes, to based off your changes), or just update the PR and close this?

@Alex-Jordan
Copy link
Copy Markdown
Author

Sure, you can just close this and move on directly. I just wanted to show the proof of concept.

@somiaj
Copy link
Copy Markdown
Owner

somiaj commented May 21, 2026

Alright. Go check it out and let me know what you think.

@somiaj somiaj closed this May 21, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants