Somiaj new grades page#15
Conversation
|
Remind me what I run to format an scss file to make it look pretty? |
e1f7f06 to
8b5e332
Compare
|
The fake buttons here are not accessible, so I need to work on that. Right now, they are actually labels for hidden checkboxes. The checked status of the checkboxes is what controls whether the table rows are hidden or not. I could reveal the checkboxes themselves, which would make it all accessible. But I want to explore if I can make it accessible without having to see those. Stepping away for now though. |
|
Maybe use local storage to store if the weights/attempts are shown/hidden. |
|
You could also add a data atribute vs a checkbox, but I'd use local storage that way it remebers a user's preference. |
| <br> | ||
| % } |
| </div> | ||
| % } | ||
| % | ||
| % if (@$open || @$reduced || @$closed) { |
There was a problem hiding this comment.
It could be possible only things begins shown are open/reduced/closed tests with either no versions taken or hidden grades, and then there wouldn't be anything to toggle. Probably rare and not worth trying to be that exact, just pointing that could happen.
|
@Alex-Jordan I took your suggestion and implemented them with javascript and using local storage to recall the user's preference. Would you like me to send the patch here (it is top of my branch, not your changes, to based off your changes), or just update the PR and close this? |
|
Sure, you can just close this and move on directly. I just wanted to show the proof of concept. |
|
Alright. Go check it out and let me know what you think. |
What do you think about these?
Those rows are hidden by default as in the first screenshot. No javascript is used for this, just css.