Fix bmp crash by putting rBMP in context for try..catch for client_thread.cpp#33
Open
fkong-cisco wants to merge 4 commits into
Open
Fix bmp crash by putting rBMP in context for try..catch for client_thread.cpp#33fkong-cisco wants to merge 4 commits into
fkong-cisco wants to merge 4 commits into
Conversation
…p PR (modeled after whitebox PR sonic-net#2) Made-with: Cursor
Keep rBMP in scope for the full ClientThread lifetime so the std::thread that uses &rBMP does not reference an object that has gone out of scope when the try block exits. Moved from inside try to just after pthread_cleanup_push. Made-with: Cursor
Made-with: Cursor
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azpw run |
Collaborator
|
Retrying failed(or canceled) jobs... |
Collaborator
|
No Azure DevOps builds found for #33. |
Collaborator
|
/azpw run Azure.sonic-bmp |
Collaborator
|
Retrying failed(or canceled) jobs... |
Collaborator
|
No Azure DevOps builds found for #33. |
Author
|
close and re-open to restart /azpw job |
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary:
Fixes a bmp crash because rBMP is used out of context in server/src/client_thread.cpp
Type of change
Back port request
Approach
What is the motivation for this PR?
Occasional crash of bmp was reported, with traceback pointing to this area. Analysis found that rBMP was declared in the "try" but referred to in the "catch"
How did you do it?
Moved the declaration just above the "try" so it has wider scope to cover its uses.
How did you verify/test it?
Tested the script with lots of bmp connection flaps. No more crashes.
Any platform specific information?