Update dynamic threshold for Q1/Q2/Q3 egress lossy profiles#27019
Closed
kperumalbfn wants to merge 2 commits into
Closed
Update dynamic threshold for Q1/Q2/Q3 egress lossy profiles#27019kperumalbfn wants to merge 2 commits into
kperumalbfn wants to merge 2 commits into
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kperumalbfn
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Arista 7060X6-64PE-B buffer Jinja templates to adjust lossy queue dynamic thresholds and broaden when queue buffer profiles are generated based on device role.
Changes:
- Updated
dynamic_thfor Q1/Q2/Q3 lossy queue profiles from-7to3(T0/T1 templates). - Expanded the
DEVICE_METADATA['localhost'].typegate to include bothLeafRouterandToRRouter(multiple templates).
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| device/arista/x86_64-arista_7060x6_64pe_b/Arista-7060X6-64PE-B-C512S2/buffers_defaults_t1.j2 | Adjusts Q1–Q3 dynamic_th; broadens device-type condition for queue buffer generation. |
| device/arista/x86_64-arista_7060x6_64pe_b/Arista-7060X6-64PE-B-C512S2/buffers_defaults_t0.j2 | Adjusts Q1–Q3 dynamic_th; broadens device-type condition for queue buffer generation. |
| device/arista/x86_64-arista_7060x6_64pe_b/Arista-7060X6-64PE-B-C448O16/buffers_defaults_t1.j2 | Adjusts Q1–Q3 dynamic_th; modifies device-type condition (currently introduces a Jinja syntax issue). |
| device/arista/x86_64-arista_7060x6_64pe_b/Arista-7060X6-64PE-B-C448O16/buffers_defaults_t0.j2 | Adjusts Q1–Q3 dynamic_th; broadens device-type condition for queue buffer generation. |
…-C448O16/buffers_defaults_t1.j2 Fix Typo Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
closing this PR, new changes are in PR - #27036 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Update the alpha values for Q1/Q2/Q3 egress profiles to provide more buffers for the traffic.
Update the egress queue profiles for all ToR/Leaf switches
Work item tracking
37712828
How I did it
Updated the dynamic threshold values for Q1/Q2/Q3 lossy queues.
How to verify it
Generated the values after updating T0/T1 Ninja templates.
Which release branch to backport (provide reason below if selected)