gbsyncd: use RESTORE REPLACE when cloning FEATURE entries#27317
Open
anamehra wants to merge 3 commits into
Open
gbsyncd: use RESTORE REPLACE when cloning FEATURE entries#27317anamehra wants to merge 3 commits into
anamehra wants to merge 3 commits into
Conversation
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: anamehra <anamehra@cisco.com>
anamehra
force-pushed
the
anamehra/gbsyncd_restore
branch
from
90534ec to
1d8cb2a
Compare
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
This PR has backport request for branch(es): 202511. ---Powered by SONiC BuildBot
|
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Anand Mehra (anamehra) anamehra@cisco.com
Why I did it
Fixes: #26670
gbsyncd seeds FEATURE and SYSLOG_CONFIG_FEATURE rows for gbsyncd by cloning
the syncd entries through Redis DUMP/RESTORE.
RESTORE without REPLACE fails when destination key exists. In current runtime, featured and gbsyncd can touch the same feature keys during bootstrap, causing intermittent BUSYKEY failures and incomplete seeding.
Work item tracking
How I did it
Use RESTORE with REPLACE so initialization succeeds even when destination keys
already exist (for example when featured updates the same keys first). This
removes bootstrap failures caused by BUSYKEY races while preserving current
design intent: gbsyncd starts with syncd-equivalent config.
How to verify it
Bringup sonic-mgmt T2 configuration with deploy-mg.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)