[dhcpmon] Log Relay-Forward / Relay-Reply counters in v6 status#75
Open
Xichen96 wants to merge 1 commit into
Open
[dhcpmon] Log Relay-Forward / Relay-Reply counters in v6 status#75Xichen96 wants to merge 1 commit into
Xichen96 wants to merge 1 commit into
Conversation
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
`dhcp_print_counters_v6()` only emits the four "endpoint" message types (Solicit, Advertise, Request, Reply). On a relay's upstream interface (e.g. PortChannel) the only DHCPv6 traffic that ever flows is encapsulated as Relay-Forward (tx) and Relay-Reply (rx), so the per-interval status line for upstream interfaces always reports zeros and the operator has no visibility into the actual relay traffic. Add a second syslog() call alongside the existing one to print the RELAY_FORW/RELAY_REPL counters. The original line is left untouched (same column widths, same content) so any log tooling that already parses it is unaffected — the relay counters appear on a new line beneath it. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Xichen96 <lukelin0907@gmail.com>
Xichen96
force-pushed
the
dev/xichenlin/dhcpmon-print-v6-relay-counters
branch
from
9d44f99 to
f919c2c
Compare
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
Follow-up to PR #62 (DHCPv6 support).
dhcp_print_counters_v6()only emits the four "endpoint" message types (Solicit, Advertise, Request, Reply). On a relay's upstream interface (e.g. a PortChannel) the only DHCPv6 traffic that ever flows is encapsulated as Relay-Forward (tx) and Relay-Reply (rx), so the per-interval status line for upstream interfaces always reports zeros and the operator has no visibility into the actual relay traffic.Work item tracking
How I did it
Add a second
syslog()call alongside the existing one to print theRELAY_FORW/RELAY_REPLcounters. The original line is left untouched (same column widths, same content) so any log tooling that already parses it is unaffected — the new relay counters appear on a fresh line beneath it.How to verify it
On a v6-relay testbed, drive Relay-Forward / Relay-Reply traffic through an upstream interface (e.g. PortChannel101) and confirm a second status line appears in syslog showing non-zero
Relay-Forward/Relay-Replyrx/tx counters for that interface. ExistingSolicit/Advertise/Request/Replyline for downstream Vlan interfaces is unchanged.Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)