Skip to content

Add one check for lossy pg hd watermark#23467

Open
JibinBao wants to merge 2 commits into
sonic-net:masterfrom
JibinBao:fix_qos_lossy_pg
Open

Add one check for lossy pg hd watermark#23467
JibinBao wants to merge 2 commits into
sonic-net:masterfrom
JibinBao:fix_qos_lossy_pg

Conversation

@JibinBao
Copy link
Copy Markdown
Contributor

@JibinBao JibinBao commented Mar 31, 2026

Description of PR

When ingress lossy PG headroom (HR) is enabled, verify that the corresponding PG0 headroom watermark and persistent watermark is greater than or equal to the packet size sent to the test port.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202205
  • 202305
  • 202311
  • 202405
  • 202411
  • 202505
  • 202511

Approach

What is the motivation for this PR?

When ingress lossy PG headroom (HR) is enabled, verify that the corresponding PG0 headroom watermark and persistent watermark is greater than or equal to the packet size sent to the test port.

How did you do it?

Add one checker in the testQosSaiLossyQueue

How did you verify/test it?

run the test on device that enabling ingress lossy PG headroom

Any platform specific information?

Device enabling enabling ingress lossy PG headroom

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Mar 31, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Mar 31, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Mar 31, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Mar 31, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Mar 31, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Mar 31, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Apr 1, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Apr 1, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@JibinBao
Copy link
Copy Markdown
Contributor Author

JibinBao commented Apr 7, 2026

/azpw run Azure.sonic-mgmt

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Apr 7, 2026

⚠️ Notice: /azpw run only runs failed jobs now. If you want to trigger a whole pipline run, please rebase your branch or close and reopen the PR.
💡 Tip: You can also use /azpw retry to retry failed jobs directly.

Retrying failed(or canceled) jobs...

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Apr 7, 2026

The following failed(or canceled) jobs were not retried:

  • kvmtest-t1-lag-vpp by Elastictest [OPTIONAL]

Job kvmtest-t1-lag-vpp by Elastictest [OPTIONAL] is an optional job and does not block the PR merge, so it will not be retried.

@JibinBao
Copy link
Copy Markdown
Contributor Author

JibinBao commented Apr 9, 2026

/azpw run Azure.sonic-mgmt

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Apr 9, 2026

⚠️ Notice: /azpw run only runs failed jobs now. If you want to trigger a whole pipline run, please rebase your branch or close and reopen the PR.
💡 Tip: You can also use /azpw retry to retry failed jobs directly.

Retrying failed(or canceled) jobs...

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Apr 9, 2026

The following failed(or canceled) jobs were not retried:

  • kvmtest-t1-lag-vpp by Elastictest [OPTIONAL]

Job kvmtest-t1-lag-vpp by Elastictest [OPTIONAL] is an optional job and does not block the PR merge, so it will not be retried.

@nhe-NV nhe-NV added Request for 202511 branch Request to backport a change to 202511 branch and removed request for 202511 labels Apr 12, 2026
@JibinBao
Copy link
Copy Markdown
Contributor Author

JibinBao commented Apr 13, 2026

/azpw run Azure.sonic-mgmt

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Apr 13, 2026

⚠️ Notice: /azpw run only runs failed jobs now. If you want to trigger a whole pipline run, please rebase your branch or close and reopen the PR.
💡 Tip: You can also use /azpw retry to retry failed jobs directly.

Retrying failed(or canceled) jobs...

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Apr 13, 2026

Build not found. Please close and reopen the PR or rebase your branch to trigger a new build.

@JibinBao JibinBao closed this Apr 20, 2026
@JibinBao JibinBao reopened this Apr 20, 2026
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Apr 20, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Apr 20, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@JibinBao
Copy link
Copy Markdown
Contributor Author

JibinBao commented Apr 20, 2026

/azpw run Azure.sonic-mgmt

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Apr 20, 2026

⚠️ Notice: /azpw run only runs failed jobs now. If you want to trigger a whole pipline run, please rebase your branch or close and reopen the PR.
💡 Tip: You can also use /azpw retry to retry failed jobs directly.

Retrying failed(or canceled) jobs...

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Apr 20, 2026

Retrying failed(or canceled) stages in build 1093228:

✅Stage Test:

  • Job impacted-area-kvmtest-multi-asic-t1 by Elastictest: retried.
  • Job impacted-area-kvmtest-t2 by Elastictest: retried.
  • Job kvmtest-t1-lag-vpp by Elastictest [OPTIONAL]: skipped (optional job and does not block the PR merge).
  • Job impacted-area-kvmtest-t0-sonic by Elastictest: retried.
  • Job impacted-area-kvmtest-t0-2vlans by Elastictest: retried.
  • Job impacted-area-kvmtest-t1-lag by Elastictest: retried.
  • Job impacted-area-kvmtest-dpu by Elastictest: retried.
  • Job impacted-area-kvmtest-t0 by Elastictest: retried.

@JibinBao JibinBao closed this Apr 21, 2026
@JibinBao JibinBao reopened this Apr 21, 2026
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Apr 21, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented Apr 21, 2026

Azure Pipelines successfully started running 1 pipeline(s).

@nhe-NV
Copy link
Copy Markdown
Contributor

nhe-NV commented Apr 21, 2026

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Apr 21, 2026

⚠️ Notice: /azpw run only runs failed jobs now. If you want to trigger a whole pipline run, please rebase your branch or close and reopen the PR.
💡 Tip: You can also use /azpw retry to retry failed jobs directly.

Retrying failed(or canceled) jobs...

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented Apr 21, 2026

Retrying failed(or canceled) stages in build 1094218:

✅Stage Test:

  • Job impacted-area-kvmtest-t1-lag by Elastictest: retried.

@JibinBao
Copy link
Copy Markdown
Contributor Author

JibinBao commented May 6, 2026

/azpw run

1 similar comment
@JibinBao
Copy link
Copy Markdown
Contributor Author

JibinBao commented May 15, 2026

/azpw run

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented May 15, 2026

⚠️ Notice: /azpw run only runs failed jobs now. If you want to trigger a whole pipline run, please rebase your branch or close and reopen the PR.
💡 Tip: You can also use /azpw retry to retry failed jobs directly.

Retrying failed(or canceled) jobs...

@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented May 15, 2026

Build not found. Please close and reopen the PR or rebase your branch to trigger a new build.

JibinBao added 2 commits May 15, 2026 09:35
@JibinBao
Add one check for lossy pg hd watermark
a0b5399 
When ingress lossy PG headroom (HR) is enabled, verify that the corresponding PG0 headroom watermark and persistent watermark is greater than or equal to the packet size sent to the test port.

Signed-off-by: jbao <jbao@nvidia.com>
@JibinBao
update testQosSaiLossyQueue
30c3d74 
Because the default interval of pg watermark is 60 seconds, change the interval to 10 and and add retry for pg headroom counter checker

Signed-off-by: jbao <jbao@nvidia.com>
@JibinBao JibinBao force-pushed the fix_qos_lossy_pg branch from 021b0a7 to 30c3d74 Compare May 15, 2026 06:36
@mssonicbld
Copy link
Copy Markdown
Collaborator

mssonicbld commented May 15, 2026

/azp run

@azure-pipelines
Copy link
Copy Markdown

azure-pipelines Bot commented May 15, 2026

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@roy-sror roy-sror roy-sror approved these changes

@nhe-NV nhe-NV nhe-NV approved these changes

@vmittal-msft vmittal-msft Awaiting requested review from vmittal-msft

@XuChen-MSFT XuChen-MSFT Awaiting requested review from XuChen-MSFT

@xwjiang-ms xwjiang-ms Awaiting requested review from xwjiang-ms

Assignees

No one assigned

Labels

Request for 202511 branch Request to backport a change to 202511 branch

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JibinBao @mssonicbld @nhe-NV @roy-sror